linux-kernel - Re: [PATCH v2 2/5] mtd: rawnand/davinci: Avoid duplicated page read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20211119184405.1404555-1-miquel.raynal@bootlin.com>
Date:   Fri, 19 Nov 2021 19:44:05 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Paul Cercueil <paul@...pouillou.net>,
        Miquel Raynal <miquel.raynal@...tlin.com>
Cc:     Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Harvey Hunt <harveyhuntnexus@...il.com>, list@...ndingux.net,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-mips@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v2 2/5] mtd: rawnand/davinci: Avoid duplicated page read

On Sat, 2021-10-16 at 13:22:25 UTC, Paul Cercueil wrote:
> The function nand_davinci_read_page_hwecc_oob_first() first reads the
> OOB data, extracts the ECC information, programs the ECC hardware before
> reading the actual data in a loop.
> 
> Right after the OOB data was read, it called nand_read_page_op() to
> reset the read cursor to the beginning of the page. This caused the
> first page to be read twice: in that call, and later in the loop.
> 
> Address that issue by changing the call to nand_read_page_op() to
> nand_change_read_column_op(), which will only reset the read cursor.
> 
> Cc: <stable@...r.kernel.org> # v5.2
> Fixes: a0ac778eb82c ("mtd: rawnand: ingenic: Add support for the JZ4740")
> Signed-off-by: Paul Cercueil <paul@...pouillou.net>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel