linux-kernel - Re: [PATCH v2 11/20] linux/container

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8d99e5cc64db64b6262b74aa7a9e04a642a7629f.camel@perches.com>
Date:   Sat, 20 Nov 2021 08:33:21 -0800
From:   Joe Perches <joe@...ches.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Alejandro Colomar <alx.manpages@...il.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Arnd Bergmann <arnd@...db.de>,
        Alexey Dobriyan <adobriyan@...il.com>,
        Jani Nikula <jani.nikula@...ux.intel.com>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH v2 11/20] linux/container_of.h: Cosmetic

On Sat, 2021-11-20 at 18:12 +0200, Andy Shevchenko wrote:
> On Sat, Nov 20, 2021 at 3:03 PM Alejandro Colomar
> <alx.manpages@...il.com> wrote:
> > 
> > Place braces in a ({}) expression
> > similarly to how a function would have them.
> 
> I don't think we need this change. ({ on one line is pretty much
> idiomatic for macros.

true

$ grep-2.5.4 -rP --include=*.[ch] -oh '\(\s*\\?\s*\{' * | \
  sort | uniq -c | sort -rn
   2756 ({
     13 {
     13 ( {
      4 (			\
      2 ( \
      2 (                                \
      2 (		\
      1 (	\
      1 (				\
      1 (					\
      1 (									\
      1 		{