linux-kernel - Re: [PATCH V2] clk: imx: imx8ulp: set suppress_bind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YZlYD4MFFrLgZeoh@ryzen>
Date:   Sat, 20 Nov 2021 22:18:23 +0200
From:   Abel Vesa <abel.vesa@....com>
To:     "Peng Fan (OSS)" <peng.fan@....nxp.com>
Cc:     sboyd@...nel.org, mturquette@...libre.com, s.hauer@...gutronix.de,
        kernel@...gutronix.de, festevam@...il.com, linux-imx@....com,
        linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Peng Fan <peng.fan@....com>
Subject: Re: [PATCH V2] clk: imx: imx8ulp: set suppress_bind_attrs to true

On 21-10-22 21:15:13, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@....com>
> 
> The clock driver is registered as platform devices and
> it is possible to reloading the driver at runtime.
> 
> But actually the clocks should never be removed to make system work,
> attempting to bind again would result in a crash, because almost all
> devices depends on clock to function well.
> 
> Signed-off-by: Peng Fan <peng.fan@....com>

Reviewed-by: Abel Vesa <abel.vesa@....com>

I'll apply it to clk/imx on Monday.

> ---
> 
> V2:
>  Update commit log to explain more
> 
>  drivers/clk/imx/clk-imx8ulp.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/imx/clk-imx8ulp.c b/drivers/clk/imx/clk-imx8ulp.c
> index 6699437e17b8..8eb1af2d6429 100644
> --- a/drivers/clk/imx/clk-imx8ulp.c
> +++ b/drivers/clk/imx/clk-imx8ulp.c
> @@ -559,6 +559,7 @@ static struct platform_driver imx8ulp_clk_driver = {
>  	.probe	= imx8ulp_clk_probe,
>  	.driver = {
>  		.name		= KBUILD_MODNAME,
> +		.suppress_bind_attrs = true,
>  		.of_match_table	= imx8ulp_clk_dt_ids,
>  	},
>  };
> -- 
> 2.30.0
>