[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <P42X2R.2KJI0X4G52WJ1@ixit.cz>
Date: Sun, 21 Nov 2021 10:53:13 +0100
From: David Heidelberg <david@...t.cz>
To: Shawn Guo <shawnguo@...nel.org>
Cc: Rob Herring <robh+dt@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
NXP Linux Team <linux-imx@....com>,
~okias/devicetree@...ts.sr.ht, phone-devel@...r.kernel.org,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: imx8mq: fix the schema check errors for
fsl,tmu-calibration
Hello Shawn,
yes, when I get back to working on Linux kernel patches, I'll resend.
David
On Sun, Nov 21 2021 at 16:51:03 +0800, Shawn Guo <shawnguo@...nel.org>
wrote:
> On Fri, Oct 29, 2021 at 01:40:49PM +0200, David Heidelberg wrote:
>> fsl,tmu-calibration is in u32-matrix. Use matching property syntax.
>> No functional changes. Fixes warnings as:
>> $ make dtbs_check
>> ...
>> arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dt.yaml:
>> tmu@...60000: fsl,tmu-calibration:0: Additional items are not
>> allowed (1, 41, 2, 47, 3, 53, 4, 61, 5, 67, 6, 75, 7, 81, 8, 87, 9,
>> 95, 10, 103, 11, 111, 65536, 27, 65537, 35, 65538, 43, 65539, 51,
>> 65540, 59, 65541, 67, 65542, 75, 65543, 85, 65544, 93, 65545, 103,
>> 65546, 112, 131072, 23, 131073, 35, 131074, 45, 131075, 55, 131076,
>> 65, 131077, 75, 131078, 87, 131079, 99, 131080, 111, 196608, 21,
>> 196609, 33, 196610, 45, 196611, 57, 196612, 69, 196613, 83, 196614,
>> 95, 196615, 113 were unexpected)
>> From schema:
>> /home/ubuntu/projects_remote/linux/Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml
>> ...
>>
>> Signed-off-by: David Heidelberg <david@...t.cz>
>> ---
>> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 87
>> ++++++++++++-----------
>> 1 file changed, 44 insertions(+), 43 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
>> b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
>> index 972766b67a15..50088b110ad4 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
>> @@ -429,49 +429,50 @@ tmu: tmu@...60000 {
>> clocks = <&clk IMX8MQ_CLK_TMU_ROOT>;
>> little-endian;
>> fsl,tmu-range = <0xb0000 0xa0026 0x80048 0x70061>;
>> - fsl,tmu-calibration = <0x00000000 0x00000023
>> - 0x00000001 0x00000029
>> - 0x00000002 0x0000002f
>> - 0x00000003 0x00000035
>> - 0x00000004 0x0000003d
>> - 0x00000005 0x00000043
>> - 0x00000006 0x0000004b
>> - 0x00000007 0x00000051
>> - 0x00000008 0x00000057
>> - 0x00000009 0x0000005f
>> - 0x0000000a 0x00000067
>> - 0x0000000b 0x0000006f
>> -
>> - 0x00010000 0x0000001b
>> - 0x00010001 0x00000023
>> - 0x00010002 0x0000002b
>> - 0x00010003 0x00000033
>> - 0x00010004 0x0000003b
>> - 0x00010005 0x00000043
>> - 0x00010006 0x0000004b
>> - 0x00010007 0x00000055
>> - 0x00010008 0x0000005d
>> - 0x00010009 0x00000067
>> - 0x0001000a 0x00000070
>> -
>> - 0x00020000 0x00000017
>> - 0x00020001 0x00000023
>> - 0x00020002 0x0000002d
>> - 0x00020003 0x00000037
>> - 0x00020004 0x00000041
>> - 0x00020005 0x0000004b
>> - 0x00020006 0x00000057
>> - 0x00020007 0x00000063
>> - 0x00020008 0x0000006f
>> -
>> - 0x00030000 0x00000015
>> - 0x00030001 0x00000021
>> - 0x00030002 0x0000002d
>> - 0x00030003 0x00000039
>> - 0x00030004 0x00000045
>> - 0x00030005 0x00000053
>> - 0x00030006 0x0000005f
>> - 0x00030007 0x00000071>;
>> + fsl,tmu-calibration =
>> + <0x00000000 0x00000023>,
>> + <0x00000001 0x00000029>,
>
> Can we keep the indentation like below?
>
> fsl,tmu-calibration = <0x00000000 0x00000023>,
> <0x00000001 0x00000029>,
> ...
>
>
> Shawn
>
>> + <0x00000002 0x0000002f>,
>> + <0x00000003 0x00000035>,
>> + <0x00000004 0x0000003d>,
>> + <0x00000005 0x00000043>,
>> + <0x00000006 0x0000004b>,
>> + <0x00000007 0x00000051>,
>> + <0x00000008 0x00000057>,
>> + <0x00000009 0x0000005f>,
>> + <0x0000000a 0x00000067>,
>> + <0x0000000b 0x0000006f>,
>> +
>> + <0x00010000 0x0000001b>,
>> + <0x00010001 0x00000023>,
>> + <0x00010002 0x0000002b>,
>> + <0x00010003 0x00000033>,
>> + <0x00010004 0x0000003b>,
>> + <0x00010005 0x00000043>,
>> + <0x00010006 0x0000004b>,
>> + <0x00010007 0x00000055>,
>> + <0x00010008 0x0000005d>,
>> + <0x00010009 0x00000067>,
>> + <0x0001000a 0x00000070>,
>> +
>> + <0x00020000 0x00000017>,
>> + <0x00020001 0x00000023>,
>> + <0x00020002 0x0000002d>,
>> + <0x00020003 0x00000037>,
>> + <0x00020004 0x00000041>,
>> + <0x00020005 0x0000004b>,
>> + <0x00020006 0x00000057>,
>> + <0x00020007 0x00000063>,
>> + <0x00020008 0x0000006f>,
>> +
>> + <0x00030000 0x00000015>,
>> + <0x00030001 0x00000021>,
>> + <0x00030002 0x0000002d>,
>> + <0x00030003 0x00000039>,
>> + <0x00030004 0x00000045>,
>> + <0x00030005 0x00000053>,
>> + <0x00030006 0x0000005f>,
>> + <0x00030007 0x00000071>;
>> #thermal-sensor-cells = <1>;
>> };
>>
>> --
>> 2.33.0
>>
Powered by blists - more mailing lists