linux-kernel - Re: [PATCH v2][linux-next] dmaengine: dw-axi-dmac: Fix uninitialized variable in axi_chan_block_xfer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YZswJ7eZO2LdJ3ST@matsya>
Date:   Mon, 22 Nov 2021 11:22:39 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Tim Gardner <tim.gardner@...onical.com>
Cc:     Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2][linux-next] dmaengine: dw-axi-dmac: Fix uninitialized
 variable in axi_chan_block_xfer_start()

On 25-10-21, 12:16, Tim Gardner wrote:
> Coverity complains of an uninitialized variable:
> 
> 5. uninit_use_in_call: Using uninitialized value config.dst_per when calling axi_chan_config_write. [show details]
> 6. uninit_use_in_call: Using uninitialized value config.hs_sel_src when calling axi_chan_config_write. [show details]
> CID 121164 (#1-3 of 3): Uninitialized scalar variable (UNINIT)
> 7. uninit_use_in_call: Using uninitialized value config.src_per when calling axi_chan_config_write. [show details]
> 418        axi_chan_config_write(chan, &config);
> 
> Fix this by initializing the structure to 0 which should at least be benign in axi_chan_config_write(). Also fix
> what looks like a cut-n-paste error when initializing config.hs_sel_dst.

Applied, thanks

-- 
~Vinod