linux-kernel - RE: [PATCH 4/4] arm64: dts: imx8ulp-evk: enable fec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB8PR04MB6795270E9F852F33300C0D24E69F9@DB8PR04MB6795.eurprd04.prod.outlook.com>
Date:   Mon, 22 Nov 2021 02:08:28 +0000
From:   Joakim Zhang <qiangqing.zhang@....com>
To:     Peng Fan <peng.fan@....com>, Andrew Lunn <andrew@...n.ch>,
        "Peng Fan (OSS)" <peng.fan@....nxp.com>
CC:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        Aisheng Dong <aisheng.dong@....com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH 4/4] arm64: dts: imx8ulp-evk: enable fec


Hi Peng,

> -----Original Message-----
> From: Peng Fan <peng.fan@....com>
> Sent: 2021年11月22日 9:04
> To: Andrew Lunn <andrew@...n.ch>; Peng Fan (OSS)
> <peng.fan@....nxp.com>
> Cc: robh+dt@...nel.org; Aisheng Dong <aisheng.dong@....com>; Joakim
> Zhang <qiangqing.zhang@....com>; davem@...emloft.net;
> kuba@...nel.org; shawnguo@...nel.org; s.hauer@...gutronix.de;
> kernel@...gutronix.de; festevam@...il.com; dl-linux-imx
> <linux-imx@....com>; netdev@...r.kernel.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org
> Subject: RE: [PATCH 4/4] arm64: dts: imx8ulp-evk: enable fec
> 
> > Subject: Re: [PATCH 4/4] arm64: dts: imx8ulp-evk: enable fec
> >
> > > +&fec {
> > > +	pinctrl-names = "default";
> > > +	pinctrl-0 = <&pinctrl_enet>;
> > > +	phy-mode = "rmii";
> >
> > Is this really a Fast Ethernet? Not 1G?
> 
> Not 1G. it only support 10M/100M ethernet.
> 
> >
> > > +	phy-handle = <&ethphy>;
> > > +	status = "okay";
> > > +
> > > +	mdio {
> > > +		#address-cells = <1>;
> > > +		#size-cells = <0>;
> > > +
> > > +		ethphy: ethernet-phy {
> > > +			reg = <1>;
> >
> > I'm surprised this does not give warnings from the DTS tools. There is
> > a reg value, so it should be ethernet-phy@1
> 
> I not see warning per my build:
> "
> *** Default configuration is based on 'defconfig'
> #
> # No change to .config
> #
>   CALL    scripts/atomic/check-atomics.sh
>   CALL    scripts/checksyscalls.sh
>   CHK     include/generated/compile.h
>   DTC     arch/arm64/boot/dts/freescale/imx8ulp-evk.dtb
> "
> Anyway I will check and fix if the node needs a fix.

According to PHY guide, Documentation/devicetree/bindings/net/ethernet-phy.yaml, yes, we need write to ' ethernet-phy@1'.

DTS tool may not complain it, I guess 'make dtbs_check' could give a warning...

Best Regards,
Joakim Zhang
> Thanks,
> Peng
> 
> >
> >   Andrew