linux-kernel - Re: [PATCH v0.9 3/6] sched/umcg: implement UMCG syscalls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 22 Nov 2021 12:17:04 -0800
From:   Peter Oskolkov <posk@...k.io>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Ingo Molnar <mingo@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Andy Lutomirski <luto@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-api@...r.kernel.org, llvm@...ts.linux.dev,
        kbuild-all@...ts.01.org,
        Linux Memory Management List <linux-mm@...ck.org>,
        Paul Turner <pjt@...gle.com>
Subject: Re: [PATCH v0.9 3/6] sched/umcg: implement UMCG syscalls

On Mon, Nov 22, 2021 at 2:02 AM kernel test robot <lkp@...el.com> wrote:
>
> Hi Peter,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on cb0e52b7748737b2cf6481fdd9b920ce7e1ebbdf]
>
> url:    https://github.com/0day-ci/linux/commits/Peter-Oskolkov/sched-mm-x86-uaccess-implement-User-Managed-Concurrency-Groups/20211122-052209
> base:   cb0e52b7748737b2cf6481fdd9b920ce7e1ebbdf
> config: x86_64-randconfig-c007-20211121 (attached as .config)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/0day-ci/linux/commit/e455791cacec2b140558a717d2b8b07f5561a251
>         git remote add linux-review https://github.com/0day-ci/linux
>         git fetch --no-tags linux-review Peter-Oskolkov/sched-mm-x86-uaccess-implement-User-Managed-Concurrency-Groups/20211122-052209
>         git checkout e455791cacec2b140558a717d2b8b07f5561a251
>         # save the attached .config to linux build tree
>         mkdir build_dir
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
>
> All errors (new ones prefixed by >>):
>
>    In file included from <built-in>:1:
> >> ./usr/include/linux/umcg.h:80:2: error: unknown type name 'u64'
>            u64     state_ts;               /* r/w */

I figured it out - lkp manages to compile uapi so that it sees
__u32/__u64 but not u32/u64. I'll make the change.

As __u64 is actually a different type from u64 (long unsigned int vs
long long unsigned int), I'll need to make corresponding changes in
other files to avoid warnings of "comparing different types" sort.

Why does the kernel have both __u64 and u64, and have them defined as
different types? (This is not really a question, just a complaint).

>            ^
> >> ./usr/include/linux/umcg.h:91:2: error: unknown type name 'u32'
>            u32     next_tid;               /* r   */
>            ^
>    ./usr/include/linux/umcg.h:93:2: error: unknown type name 'u32'
>            u32     flags;                  /* Reserved; must be zero. */
>            ^
>    ./usr/include/linux/umcg.h:101:2: error: unknown type name 'u64'
>            u64     idle_workers_ptr;       /* r/w */
>            ^
>    ./usr/include/linux/umcg.h:107:2: error: unknown type name 'u64'
>            u64     idle_server_tid_ptr;    /* r   */
>            ^
>    5 errors generated.
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org