linux-kernel - Re: [RFC PATCH v1 1/1] docs: add the new commit-msg tags 'Reported:' and 'Reviewed:'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211122152426.7c2b3ab4@gandalf.local.home>
Date:   Mon, 22 Nov 2021 15:24:26 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Thorsten Leemhuis <linux@...mhuis.info>
Cc:     workflows@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Konstantin Ryabitsev <konstantin@...uxfoundation.org>,
        Jonathan Corbet <corbet@....net>
Subject: Re: [RFC PATCH v1 1/1] docs: add the new commit-msg tags
 'Reported:' and 'Reviewed:'

On Mon, 22 Nov 2021 19:50:35 +0100
Thorsten Leemhuis <linux@...mhuis.info> wrote:

> > That said, I would like a way to have versions show a link to the last
> > version that was reviewed.
> > 
> > v1: has no tags
> > 
> > v2: has a Reviewed: tag to v1.
> > 
> > v3: has a Reviewed: tag to v2
> > 
> > [...]
> > 
> > Then the final commit could have a "Link" or "Reviewed" tag to v3, even
> > though there may not be any reviews to v3, but v3 has the link to v2, and
> > v2 has the link to v1, etc.  
> 
> Is that really worth it? Isn't it sufficient if the commit links to the
> last public review posting, as that already should link to all earlier
> review postings. Sure, not everybody is doing this right now, but maybe
> just educating people to do so is better than creating something new.

Isn't "as that already should link to all earlier review postings" what I'm
suggesting above? I haven't seen many people do that yet.

-- Steve