linux-kernel - Re: [PATCH] staging: r8188eu: remove unnecessary NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52ad7e4f-7164-e868-ca49-2f0fecda3395@gmail.com>
Date:   Tue, 23 Nov 2021 00:22:13 +0300
From:   Pavel Skripkin <paskripkin@...il.com>
To:     Vihas Mak <makvihas@...il.com>, Larry.Finger@...inger.net,
        phil@...lpotter.co.uk
Cc:     gregkh@...uxfoundation.org, straube.linux@...il.com,
        martin@...ser.cx, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: remove unnecessary NULL check

On 11/22/21 22:53, Vihas Mak wrote:
> remove unnecessary NULL check surrounding rtw_free_netdev(), as the check
> is already performed inside rtw_free_netdev() in
> drivers/staging/r8188eu/os_dep/osdep_service.c.
> 
> Signed-off-by: Vihas Mak <makvihas@...il.com>

Reviewed-by: Pavel Skripkin <paskripkin@...il.com>

BTW, same can be done in rtw_usb_if1_init().



With regards,
Pavel Skripkin