linux-kernel - Re: [PATCH v2 2/3] dt-bindings: i2c: apple,i2c: allow multiple compatibles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d3caf42a8fea181b@bloch.sibelius.xs4all.nl>
Date:   Mon, 22 Nov 2021 23:39:12 +0100 (CET)
From:   Mark Kettenis <mark.kettenis@...all.nl>
To:     Janne Grunau <j@...nau.net>
Cc:     marcan@...can.st, sven@...npeter.dev, alyssa@...enzweig.io,
        robh+dt@...nel.org, wsa@...nel.org, olof@...om.net, arnd@...db.de,
        kettenis@...nbsd.org, robh@...nel.org,
        linux-arm-kernel@...ts.infradead.org, linux-i2c@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] dt-bindings: i2c: apple,i2c: allow multiple compatibles

> From: Janne Grunau <j@...nau.net>
> Date: Mon, 22 Nov 2021 23:24:39 +0100
> 
> The intention was to have a SoC-specific and base compatible string
> to allow forward compatibility and SoC specific quirks,
> 
> Fixes: df7c4a8c1b47 ("dt-bindings: i2c: Add Apple I2C controller bindings")
> Signed-off-by: Janne Grunau <j@...nau.net>
> Cc: Mark Kettenis <kettenis@...nbsd.org>
> Reviewed-by: Sven Peter <sven@...npeter.dev>

Reviewed-by: Mark Kettenis <kettenis@...nbsd.org>

> ---
>  Documentation/devicetree/bindings/i2c/apple,i2c.yaml | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/apple,i2c.yaml b/Documentation/devicetree/bindings/i2c/apple,i2c.yaml
> index 22fc8483256f..82b953181a52 100644
> --- a/Documentation/devicetree/bindings/i2c/apple,i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/apple,i2c.yaml
> @@ -20,9 +20,9 @@ allOf:
>  
>  properties:
>    compatible:
> -    enum:
> -      - apple,t8103-i2c
> -      - apple,i2c
> +    items:
> +      - const: apple,t8103-i2c
> +      - const: apple,i2c
>  
>    reg:
>      maxItems: 1
> @@ -51,7 +51,7 @@ unevaluatedProperties: false
>  examples:
>    - |
>      i2c@...10000 {
> -      compatible = "apple,t8103-i2c";
> +      compatible = "apple,t8103-i2c", "apple,i2c";
>        reg = <0x35010000 0x4000>;
>        interrupt-parent = <&aic>;
>        interrupts = <0 627 4>;
> -- 
> 2.34.0
> 
>