linux-kernel - Re: linux-next: Fixes tag needs some work in the hid tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d617396a-20b7-41fd-bcf4-b5854a3c2e7d@t-8ch.de>
Date:   Mon, 22 Nov 2021 23:59:26 +0100
From:   Thomas Weißschuh <linux@...ssschuh.net>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the hid tree

Hi Stephen,

On 2021-11-23 08:17+1100, Stephen Rothwell wrote:
> In commit
> 
>   3e6a950d9836 ("HID: input: set usage type to key on keycode remap")
> 
> Fixes tag
> 
>   Fixes: bcfa8d1457 ("HID: input: Add support for Programmable Buttons")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").

Thanks for the pointer. I'll make sure to do this correctly in the future.
Maybe this should be part of checkpatch.pl?

> Fixes tag
> 
>   Fixes: f5854fad39 ("Input: hid-input - allow mapping unknown usages")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").

Thomas