linux-kernel - Re: [PATCH v6] clk: Add write operation for clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEG3pNCxuPNwqvRWnMuFNMmiV0nZRwC+1M69jVC=uMyS5Jie6Q@mail.gmail.com>
Date:   Tue, 23 Nov 2021 11:43:55 -0600
From:   Michael Turquette <mturquette@...libre.com>
To:     Sam Protsenko <semen.protsenko@...aro.org>
Cc:     Stephen Boyd <sboyd@...nel.org>,
        Russell King <linux@...linux.org.uk>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Mike Tipton <mdtipton@...eaurora.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Andy Shevchenko <andy@...nel.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        linux-clk <linux-clk@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Fabio Estevam <festevam@...il.com>
Subject: Re: [PATCH v6] clk: Add write operation for clk_parent debugfs node

On Mon, Nov 22, 2021 at 10:03 AM Sam Protsenko
<semen.protsenko@...aro.org> wrote:
>
> On Tue, 19 Oct 2021 at 16:32, Sam Protsenko <semen.protsenko@...aro.org> wrote:
> >
> > On Wed, 13 Oct 2021 at 21:04, Fabio Estevam <festevam@...il.com> wrote:
> > >
> > > Hi Sam,
> > >
> > > On Wed, Oct 13, 2021 at 2:20 PM Sam Protsenko
> > > <semen.protsenko@...aro.org> wrote:
> > > >
> > > > Useful for testing mux clocks. One can write the index of the parent to
> > > > be set into clk_parent node, starting from 0. Example
> > > >
> > > >     # cd /sys/kernel/debug/clk/mout_peri_bus
> > > >     # cat clk_possible_parents
> > > >       dout_shared0_div4 dout_shared1_div4
> > > >     # cat clk_parent
> > > >       dout_shared0_div4
> > > >     # echo 1 > clk_parent
> > > >     # cat clk_parent
> > > >       dout_shared1_div4
> > > >
> > > > CLOCK_ALLOW_WRITE_DEBUGFS has to be defined in drivers/clk/clk.c in
> > > > order to use this feature.
> > > >
> > > > Signed-off-by: Sam Protsenko <semen.protsenko@...aro.org>
> > > > Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> > >
> > > This is useful, thanks:
> > >
> > > Reviewed-by: Fabio Estevam <festevam@...il.com>
> >
> > Hi Michael, Stephen,
> >
> > If there are no outstanding comments, can you please take this one?
> >
>
> Bump.

Looks good to me.

Acked-by: Michael Turquette <mturquette@...libre.com>

Stephen, can you take it into your tree?

Best,
Mike

>
> > Thanks!



-- 
Michael Turquette
CEO - Los Angeles, CA
http://baylibre.com/