linux-kernel - Re: [PATCH 1/1] tty: serial: uartlite: allow 64 bit address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YZ05/73+BhIANNGF@kroah.com>
Date:   Tue, 23 Nov 2021 19:59:11 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Lizhi Hou <lizhi.hou@...inx.com>
Cc:     linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
        jacmet@...site.dk
Subject: Re: [PATCH 1/1] tty: serial: uartlite: allow 64 bit address

On Tue, Nov 23, 2021 at 10:45:06AM -0800, Lizhi Hou wrote:
> Fix the uartlite probe failure when it is mapped to address above 4G.

Fix it how?

> Signed-off-by: Lizhi Hou <lizhi.hou@...inx.com>

What commit caused this problem?  What commit does this fix?  Should it
go to stable kernels?

> ---
>  drivers/tty/serial/uartlite.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/uartlite.c b/drivers/tty/serial/uartlite.c
> index d3d9566e5dbd..e1fa52d31474 100644
> --- a/drivers/tty/serial/uartlite.c
> +++ b/drivers/tty/serial/uartlite.c
> @@ -626,7 +626,7 @@ static struct uart_driver ulite_uart_driver = {
>   *
>   * Returns: 0 on success, <0 otherwise
>   */
> -static int ulite_assign(struct device *dev, int id, u32 base, int irq,
> +static int ulite_assign(struct device *dev, int id, phys_addr_t base, int irq,
>  			struct uartlite_data *pdata)

So you changed the variable type which does what exactly here?

thanks,

greg k-h