[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <J4K13R.CGVJ0IY95LC51@crapouillou.net>
Date: Tue, 23 Nov 2021 20:12:19 +0000
From: Paul Cercueil <paul@...pouillou.net>
To: "H. Nikolaus Schaller" <hns@...delico.com>
Cc: Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
Geert Uytterhoeven <geert+renesas@...der.be>,
Kees Cook <keescook@...omium.org>,
"Eric W. Biederman" <ebiederm@...ssion.com>,
Miquel Raynal <miquel.raynal@...tlin.com>,
David Airlie <airlied@...ux.ie>,
Daniel Vetter <daniel@...ll.ch>,
Neil Armstrong <narmstrong@...libre.com>,
Robert Foss <robert.foss@...aro.org>,
Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
Jernej Skrabec <jernej.skrabec@...il.com>,
Ezequiel Garcia <ezequiel@...labora.com>,
Harry Wentland <harry.wentland@....com>,
Sam Ravnborg <sam@...nborg.org>,
Maxime Ripard <maxime@...no.tech>,
Hans Verkuil <hverkuil-cisco@...all.nl>,
Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>,
Paul Boddie <paul@...die.org.uk>, devicetree@...r.kernel.org,
linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
letux-kernel@...nphoenux.org, Jonas Karlman <jonas@...boo.se>,
dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v8 0/8] MIPS: JZ4780 and CI20 HDMI
Hi Nikolaus,
I think if you can fix the last few things I commented on, and I get an
ACK from Rob for the Device Tree related patches, then it will be ready
to merge.
Cheers,
-Paul
Le mar., nov. 23 2021 at 19:13:53 +0100, H. Nikolaus Schaller
<hns@...delico.com> a écrit :
> PATCH V8 2021-11-23 19:14:00:
> - fix a bad editing result from patch 2/8 (found by
> paul@...pouillou.net)
>
> PATCH V7 2021-11-23 18:46:23:
> - changed gpio polarity of hdmi_power to 0 (suggested by
> paul@...pouillou.net)
> - fixed LCD1 irq number (bug found by paul@...pouillou.net)
> - removed "- 4" for calculating max_register (suggested by
> paul@...pouillou.net)
> - use unevaluatedPropertes instead of additionalProperties (suggested
> by robh@...nel.org)
> - moved and renamed ingenic,jz4780-hdmi.yaml (suggested by
> robh@...nel.org)
> - adjusted assigned-clocks changes to upstream which added some for
> SSI (by hns@...delico.com)
> - rebased and tested with v5.16-rc2 + patch set drm/ingenic by
> paul@...pouillou.net (by hns@...delico.com)
>
> PATCH V6 2021-11-10 20:43:33:
> - changed CONFIG_DRM_INGENIC_DW_HDMI to "m" (by hns@...delico.com)
> - made ingenic-dw-hdmi an independent platform driver which can be
> compiled as module
> and removed error patch fixes for IPU (suggested by
> paul@...pouillou.net)
> - moved assigned-clocks from jz4780.dtsi to ci20.dts (suggested by
> paul@...pouillou.net)
> - fixed reg property in jz4780.dtsi to cover all registers incl.
> gamma and vee (by hns@...delico.com)
> - added a base patch to calculate regmap size from DTS reg property
> (requested by paul@...pouillou.net)
> - restored resetting all bits except one in LCDOSDC (requested by
> paul@...pouillou.net)
> - clarified setting of cpos (suggested by paul@...pouillou.net)
> - moved bindings definition for ddc-i2c-bus (suggested by
> paul@...pouillou.net)
> - simplified mask definitions for JZ_LCD_DESSIZE (requested by
> paul@...pouillou.net)
> - removed setting alpha premultiplication (suggested by
> paul@...pouillou.net)
> - removed some comments (suggested by paul@...pouillou.net)
>
> PATCH V5 2021-10-05 14:28:44:
> - dropped mode_fixup and timings support in dw-hdmi as it is no
> longer needed in this V5 (by hns@...delico.com)
> - dropped "drm/ingenic: add some jz4780 specific features"
> (stimulated by paul@...pouillou.net)
> - fixed typo in commit subject: "synopsis" -> "synopsys" (by
> hns@...delico.com)
> - swapped clocks in jz4780.dtsi to match synopsys,dw-hdmi.yaml (by
> hns@...delico.com)
> - improved, simplified, fixed, dtbschecked ingenic-jz4780-hdmi.yaml
> and made dependent of bridge/synopsys,dw-hdmi.yaml (based on
> suggestions by maxime@...no.tech)
> - fixed binding vs. driver&DTS use of hdmi-5v regulator (suggested by
> maxime@...no.tech)
> - dropped "drm/bridge: synopsis: Fix to properly handle HPD" - was a
> no longer needed workaround for a previous version
> (suggested by maxime@...no.tech)
>
> PATCH V4 2021-09-27 18:44:38:
> - fix setting output_port = 1 (issue found by paul@...pouillou.net)
> - ci20.dts: convert to use hdmi-connector (by hns@...delico.com)
> - add a hdmi-regulator to control +5V power (by hns@...delico.com)
> - added a fix to dw-hdmi to call drm_kms_helper_hotplug_event on
> plugin event detection (by hns@...delico.com)
> - always allocate extended descriptor but initialize only for jz4780
> (by hns@...delico.com)
> - updated to work on top of "[PATCH v3 0/6] drm/ingenic: Various
> improvements v3" (by paul@...pouillou.net)
> - rebased to v5.13-rc3
>
> PATCH V3 2021-08-08 07:10:50:
> This series adds HDMI support for JZ4780 and CI20 board (and fixes
> one IPU related issue in registration error path)
> - [patch 1/8] switched from mode_fixup to atomic_check (suggested by
> robert.foss@...aro.org)
> - the call to the dw-hdmi specialization is still called mode_fixup
> - [patch 3/8] diverse fixes for ingenic-drm-drv (suggested by
> paul@...pouillou.net)
> - factor out some non-HDMI features of the jz4780 into a separate
> patch
> - multiple fixes around max height
> - do not change regmap config but a copy on stack
> - define some constants
> - factor out fixing of drm_init error path for IPU into separate
> patch
> - use FIELD_PREP()
> - [patch 8/8] conversion to component framework dropped (suggested by
> Laurent.pinchart@...asonboard.com and paul@...pouillou.net)
>
> PATCH V2 2021-08-05 16:08:05:
> - code and commit messages revisited for checkpatch warnings
> - rebased on v5.14-rc4
> - include (failed, hence RFC 8/8) attempt to convert to component
> framework
> (was suggested by Paul Cercueil <paul@...pouillou.net> a while ago)
>
> This series adds HDMI support for JZ4780 and CI20 board
>
>
>
> H. Nikolaus Schaller (3):
> drm/ingenic: prepare ingenic drm for later addition of JZ4780
> MIPS: defconfig: CI20: configure for DRM_DW_HDMI_JZ4780
> [RFC] MIPS: DTS: Ingenic: adjust register size to available
> registers
>
> Paul Boddie (4):
> drm/ingenic: Add support for JZ4780 and HDMI output
> drm/ingenic: Add dw-hdmi driver for jz4780
> MIPS: DTS: jz4780: Account for Synopsys HDMI driver and LCD
> controllers
> MIPS: DTS: CI20: Add DT nodes for HDMI setup
>
> Sam Ravnborg (1):
> dt-bindings: display: Add ingenic,jz4780-dw-hdmi DT Schema
>
> .../display/bridge/ingenic,jz4780-hdmi.yaml | 76 +++++++++++
> .../display/bridge/synopsys,dw-hdmi.yaml | 3 +
> arch/mips/boot/dts/ingenic/ci20.dts | 83 ++++++++++-
> arch/mips/boot/dts/ingenic/jz4725b.dtsi | 2 +-
> arch/mips/boot/dts/ingenic/jz4740.dtsi | 2 +-
> arch/mips/boot/dts/ingenic/jz4770.dtsi | 2 +-
> arch/mips/boot/dts/ingenic/jz4780.dtsi | 40 ++++++
> arch/mips/configs/ci20_defconfig | 6 +
> drivers/gpu/drm/ingenic/Kconfig | 9 ++
> drivers/gpu/drm/ingenic/Makefile | 1 +
> drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 62 ++++++++-
> drivers/gpu/drm/ingenic/ingenic-drm.h | 38 ++++++
> drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c | 129
> ++++++++++++++++++
> 13 files changed, 444 insertions(+), 9 deletions(-)
> create mode 100644
> Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml
> create mode 100644 drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c
>
> --
> 2.33.0
>
Powered by blists - more mailing lists