linux-kernel - RE: [PATCH v2 11/13] mmc: sdhci-esdhc-imx: Add sdhc support for i.MXRT series

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 23 Nov 2021 04:31:49 +0000
From:   Bough Chen <haibo.chen@....com>
To:     Jesse Taube <mr.bossman075@...il.com>,
        dl-linux-imx <linux-imx@....com>
CC:     "mturquette@...libre.com" <mturquette@...libre.com>,
        "sboyd@...nel.org" <sboyd@...nel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
        Aisheng Dong <aisheng.dong@....com>,
        "stefan@...er.ch" <stefan@...er.ch>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "arnd@...db.de" <arnd@...db.de>, "olof@...om.net" <olof@...om.net>,
        "soc@...nel.org" <soc@...nel.org>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        Abel Vesa <abel.vesa@....com>,
        "adrian.hunter@...el.com" <adrian.hunter@...el.com>,
        "jirislaby@...nel.org" <jirislaby@...nel.org>,
        "giulio.benetti@...ettiengineering.com" 
        <giulio.benetti@...ettiengineering.com>,
        "nobuhiro1.iwamatsu@...hiba.co.jp" <nobuhiro1.iwamatsu@...hiba.co.jp>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>
Subject: RE: [PATCH v2 11/13] mmc: sdhci-esdhc-imx: Add sdhc support for
 i.MXRT series


> -----Original Message-----
> From: Jesse Taube [mailto:mr.bossman075@...il.com]
> Sent: 2021年11月23日 11:14
> To: Bough Chen <haibo.chen@....com>; dl-linux-imx <linux-imx@....com>
> Cc: mturquette@...libre.com; sboyd@...nel.org; robh+dt@...nel.org;
> shawnguo@...nel.org; s.hauer@...gutronix.de; kernel@...gutronix.de;
> festevam@...il.com; ulf.hansson@...aro.org; Aisheng Dong
> <aisheng.dong@....com>; stefan@...er.ch; linus.walleij@...aro.org;
> gregkh@...uxfoundation.org; arnd@...db.de; olof@...om.net;
> soc@...nel.org; linux@...linux.org.uk; Abel Vesa <abel.vesa@....com>;
> adrian.hunter@...el.com; jirislaby@...nel.org;
> giulio.benetti@...ettiengineering.com; nobuhiro1.iwamatsu@...hiba.co.jp;
> linux-clk@...r.kernel.org; devicetree@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org;
> linux-mmc@...r.kernel.org; linux-gpio@...r.kernel.org;
> linux-serial@...r.kernel.org
> Subject: Re: [PATCH v2 11/13] mmc: sdhci-esdhc-imx: Add sdhc support for
> i.MXRT series
> 
> 
> 
> On 11/2/21 22:19, Bough Chen wrote:
> >> -----Original Message-----
> >> From: Jesse Taube [mailto:mr.bossman075@...il.com]
> >> Sent: 2021年11月3日 6:57
> >> To: dl-linux-imx <linux-imx@....com>
> >> Cc: mturquette@...libre.com; sboyd@...nel.org; robh+dt@...nel.org;
> >> shawnguo@...nel.org; s.hauer@...gutronix.de; kernel@...gutronix.de;
> >> festevam@...il.com; ulf.hansson@...aro.org; Aisheng Dong
> >> <aisheng.dong@....com>; stefan@...er.ch; linus.walleij@...aro.org;
> >> gregkh@...uxfoundation.org; arnd@...db.de; olof@...om.net;
> >> soc@...nel.org; linux@...linux.org.uk; Abel Vesa <abel.vesa@....com>;
> >> adrian.hunter@...el.com; jirislaby@...nel.org;
> >> giulio.benetti@...ettiengineering.com;
> >> nobuhiro1.iwamatsu@...hiba.co.jp; Mr.Bossman075@...il.com;
> >> linux-clk@...r.kernel.org; devicetree@...r.kernel.org;
> >> linux-arm-kernel@...ts.infradead.org;
> >> linux-kernel@...r.kernel.org; linux-mmc@...r.kernel.org;
> >> linux-gpio@...r.kernel.org; linux-serial@...r.kernel.org; Jesse Taube
> >> <mr.bossman075@...il.com>
> >> Subject: [PATCH v2 11/13] mmc: sdhci-esdhc-imx: Add sdhc support for
> > i.MXRT
> >> series
> >>
> >> From: Jesse Taube <mr.bossman075@...il.com>
> >>
> >> Add support for i.MXRT1050's sdhc.
> >>
> >> Cc: Giulio Benetti <giulio.benetti@...ettiengineering.com>
> >> Signed-off-by: Jesse Taube <Mr.Bossman075@...il.com>---
> >> V1->V2:
> >> * Nothing done
> >> ---
> >>   drivers/mmc/host/sdhci-esdhc-imx.c | 7 +++++++
> >>   1 file changed, 7 insertions(+)
> >>
> >> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c
> >> b/drivers/mmc/host/sdhci-esdhc-imx.c
> >> index afaf33707d46..c852a6df5611 100644
> >> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> >> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> >> @@ -305,6 +305,12 @@ static struct esdhc_soc_data usdhc_imx7ulp_data
> = {
> >>   			| ESDHC_FLAG_PMQOS | ESDHC_FLAG_HS400
> >>   			| ESDHC_FLAG_STATE_LOST_IN_LPMODE,
> >>   };
> >> +static struct esdhc_soc_data usdhc_imxrt_data = {
> >> +	.flags = ESDHC_FLAG_USDHC | ESDHC_FLAG_MAN_TUNING
> >> +			| ESDHC_FLAG_HS200 | ESDHC_FLAG_ERR004536
> >> +			| ESDHC_FLAG_BROKEN_AUTO_CMD23,
> >> +};
> >> +
> >
> > Hi Jesse,
> > 	I have few question here.
> > 	Why only use manual tuning here? Does this usdhc don't support
> > standard tuning? or meet any issue when use standard tuning?
> No std tuning works, so does cmd23, i changed it to use them.

Okay.

> > 	Please also double check why not use ADMA in default? Any issue
> > found?
> Yes this is the output with ADMA:
> [0.00] mmc0: Unable to allocate ADMA buffers - falling back to standard DMA
> NOTE: I did not look into why this occurs.

If you config enough space for CMA or DMA pool, I think dma_alloc_corherent() should not meet issue.
ADMA descriptor do not large than one page(4KB). This is not big. Seems strange.

Please double check this. If this is really a limitation on imxRT, I'm okay to use SDMA as default.

Best Regards
Haibo chen
> >
> >
> > Best Regards
> > Haibo Chen
> >>
> >>   static struct esdhc_soc_data usdhc_imx8qxp_data = {
> >>   	.flags = ESDHC_FLAG_USDHC | ESDHC_FLAG_STD_TUNING @@
> -357,6
> >> +363,7 @@ static const struct of_device_id imx_esdhc_dt_ids[] = {
> >>   	{ .compatible = "fsl,imx7ulp-usdhc", .data = &usdhc_imx7ulp_data, },
> >>   	{ .compatible = "fsl,imx8qxp-usdhc", .data =
> &usdhc_imx8qxp_data, },
> >>   	{ .compatible = "fsl,imx8mm-usdhc", .data =
> &usdhc_imx8mm_data, },
> >> +	{ .compatible = "fsl,imxrt-usdhc", .data = &usdhc_imxrt_data, },
> >>   	{ .compatible = "nxp,s32g2-usdhc", .data = &usdhc_s32g2_data, },
> >>   	{ /* sentinel */ }
> >>   };
> >> --
> >> 2.33.1
> >

Download attachment "smime.p7s" of type "application/pkcs7-signature" (9551 bytes)