| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 23 Nov 2021 02:15:01 +0200
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Adam Ford <aford173@...il.com>
Cc: arm-soc <linux-arm-kernel@...ts.infradead.org>,
Tim Harvey <tharvey@...eworks.com>,
Schrempf Frieder <frieder.schrempf@...tron.de>,
linux-media <linux-media@...r.kernel.org>,
Adam Ford-BE <aford@...conembedded.com>,
cstevens@...conembedded.com,
Jagan Teki <jagan@...rulasolutions.com>,
Rob Herring <robh+dt@...nel.org>,
Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
NXP Linux Team <linux-imx@....com>,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will@...nel.org>,
Lucas Stach <l.stach@...gutronix.de>,
Peng Fan <peng.fan@....com>,
devicetree <devicetree@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2 4/5] arm64: dts: imx8mm-beacon: Enable OV5640 Camera
Hi Adam,
On Sun, Nov 21, 2021 at 09:07:26PM -0600, Adam Ford wrote:
> On Sun, Nov 21, 2021 at 5:18 PM Laurent Pinchart wrote:
> > On Sat, Nov 06, 2021 at 10:54:26AM -0500, Adam Ford wrote:
> > > The baseboard has support for a TDNext 5640 Camera which
> > > uses an OV5640 connected to a 2-lane CSI2 interface.
> > >
> > > With the CSI and mipi_csi2 drivers pointing to an OV5640 camera, the media
> > > pipeline can be configured with the following:
> > >
> > > media-ctl --links "'ov5640 1-003c':0->'imx7-mipi-csis.0':0[1]"
> > >
> > > The camera and various nodes in the pipeline can be configured for UYVY:
> > > media-ctl -v -V "'ov5640 1-003c':0 [fmt:UYVY8_1X16/640x480 field:none]"
> > > media-ctl -v -V "'csi':0 [fmt:UYVY8_1X16/640x480 field:none]"
> > >
> > > Signed-off-by: Adam Ford <aford173@...il.com>
> >
> > As the ov5640 is on an add-on module, would a DT overlay be better ?
>
> At least for the Beacon / LogicPD boards, I would prefer to avoid the
> overlays. We have an i.M6Q and an OMAP3 board with cameras enabled in
> our development kit device trees. If the cameras are not connected,
> they just display a message that the cameras are not communicating and
> move on. I'm OK with that.
You know the board better than I do, so I won't push against this, but I
still think it may not lead to the best user experience, especially if a
user wanted to connect a different sensor to the development board.
> > > ---
> > > V2: No change
> > >
> > > .../freescale/imx8mm-beacon-baseboard.dtsi | 58 +++++++++++++++++++
> > > 1 file changed, 58 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi
> > > index 6f5e63696ec0..0fb95f4a5e78 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi
> > > @@ -43,6 +43,16 @@ reg_audio: regulator-audio {
> > > enable-active-high;
> > > };
> > >
> > > + reg_camera: regulator-camera {
> > > + compatible = "regulator-fixed";
> > > + regulator-name = "mipi_pwr";
> > > + regulator-min-microvolt = <2800000>;
> > > + regulator-max-microvolt = <2800000>;
> > > + gpio = <&pca6416_1 0 GPIO_ACTIVE_HIGH>;
> > > + enable-active-high;
> > > + startup-delay-us = <100000>;
> > > + };
> > > +
> > > reg_usdhc2_vmmc: regulator-usdhc2 {
> > > compatible = "regulator-fixed";
> > > regulator-name = "VSD_3V3";
> > > @@ -67,6 +77,10 @@ sound {
> > > };
> > > };
> > >
> > > +&csi {
> > > + status = "okay";
> > > +};
> > > +
> > > &ecspi2 {
> > > pinctrl-names = "default";
> > > pinctrl-0 = <&pinctrl_espi2>;
> > > @@ -90,6 +104,30 @@ &i2c2 {
> > > pinctrl-names = "default";
> > > pinctrl-0 = <&pinctrl_i2c2>;
> > > status = "okay";
> > > +
> > > + camera@3c {
> > > + compatible = "ovti,ov5640";
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&pinctrl_ov5640>;
> > > + reg = <0x3c>;
> > > + clocks = <&clk IMX8MM_CLK_CLKO1>;
> > > + clock-names = "xclk";
> > > + assigned-clocks = <&clk IMX8MM_CLK_CLKO1>;
> > > + assigned-clock-parents = <&clk IMX8MM_CLK_24M>;
> > > + assigned-clock-rates = <24000000>;
> > > + AVDD-supply = <®_camera>; /* 2.8v */
> > > + powerdown-gpios = <&gpio1 7 GPIO_ACTIVE_HIGH>;
> > > + reset-gpios = <&gpio1 6 GPIO_ACTIVE_LOW>;
> > > +
> > > + port {
> > > + /* MIPI CSI-2 bus endpoint */
> > > + ov5640_to_mipi_csi2: endpoint {
> > > + remote-endpoint = <&imx8mm_mipi_csi_in>;
> > > + clock-lanes = <0>;
> > > + data-lanes = <1 2>;
> > > + };
> > > + };
> > > + };
> > > };
> > >
> > > &i2c4 {
> > > @@ -141,6 +179,18 @@ pca6416_1: gpio@21 {
> > > };
> > > };
> > >
> > > +&mipi_csi {
> > > + status = "okay";
> > > + ports {
> > > + port@0 {
> > > + imx8mm_mipi_csi_in: endpoint {
> > > + remote-endpoint = <&ov5640_to_mipi_csi2>;
> > > + data-lanes = <1 2>;
> > > + };
> > > + };
> > > + };
> > > +};
> > > +
> > > &sai3 {
> > > pinctrl-names = "default";
> > > pinctrl-0 = <&pinctrl_sai3>;
> > > @@ -209,6 +259,14 @@ MX8MM_IOMUXC_SAI3_RXFS_GPIO4_IO28 0x41
> > > >;
> > > };
> > >
> > > + pinctrl_ov5640: ov5640grp {
> > > + fsl,pins = <
> > > + MX8MM_IOMUXC_GPIO1_IO07_GPIO1_IO7 0x19
> > > + MX8MM_IOMUXC_GPIO1_IO06_GPIO1_IO6 0x19
> > > + MX8MM_IOMUXC_GPIO1_IO14_CCMSRCGPCMIX_CLKO1 0x59
> > > + >;
> > > + };
> > > +
> > > pinctrl_pcal6414: pcal6414-gpiogrp {
> > > fsl,pins = <
> > > MX8MM_IOMUXC_SAI2_MCLK_GPIO4_IO27 0x19
--
Regards,
Laurent Pinchart
Powered by blists - more mailing lists