linux-kernel - Re: [PATCH] usb: dwc2: gadget: use existing helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d18a3b7c-c6ec-5967-d0d3-8fdbb0716cd5@synopsys.com>
Date:   Tue, 23 Nov 2021 05:17:15 +0000
From:   Minas Harutyunyan <Minas.Harutyunyan@...opsys.com>
To:     John Keeping <john@...anate.com>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: dwc2: gadget: use existing helper

On 11/22/2021 4:31 PM, John Keeping wrote:
> All other checks of params.g_dma_desc in this file use the
> using_desc_dma() helper function.  Use that helper in two more places
> for consistency throughout the file.
> 
> Signed-off-by: John Keeping <john@...anate.com>

Acked-by: Minas Harutyunyan <Minas.Harutyunyan@...opsys.com>

> ---
>   drivers/usb/dwc2/gadget.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
> index ab8d7dad9f567..b884a83b26a6e 100644
> --- a/drivers/usb/dwc2/gadget.c
> +++ b/drivers/usb/dwc2/gadget.c
> @@ -5217,7 +5217,7 @@ int dwc2_restore_device_registers(struct dwc2_hsotg *hsotg, int remote_wakeup)
>   		 * as result BNA interrupt asserted on hibernation exit
>   		 * by restoring from saved area.
>   		 */
> -		if (hsotg->params.g_dma_desc &&
> +		if (using_desc_dma(hsotg) &&
>   		    (dr->diepctl[i] & DXEPCTL_EPENA))
>   			dr->diepdma[i] = hsotg->eps_in[i]->desc_list_dma;
>   		dwc2_writel(hsotg, dr->dtxfsiz[i], DPTXFSIZN(i));
> @@ -5229,7 +5229,7 @@ int dwc2_restore_device_registers(struct dwc2_hsotg *hsotg, int remote_wakeup)
>   		 * as result BNA interrupt asserted on hibernation exit
>   		 * by restoring from saved area.
>   		 */
> -		if (hsotg->params.g_dma_desc &&
> +		if (using_desc_dma(hsotg) &&
>   		    (dr->doepctl[i] & DXEPCTL_EPENA))
>   			dr->doepdma[i] = hsotg->eps_out[i]->desc_list_dma;
>   		dwc2_writel(hsotg, dr->doepdma[i], DOEPDMA(i));
>