linux-kernel - Re: [PATCH] of/irq: Add a quirk for controllers with their own definition of interrupt-map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <39e2b51913ef6049103d3cb67df9048514c12484.camel@svanheule.net>
Date:   Tue, 23 Nov 2021 09:40:29 +0100
From:   Sander Vanheule <sander@...nheule.net>
To:     Marc Zyngier <maz@...nel.org>, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Cc:     kernel-team@...roid.com, Rob Herring <robh@...nel.org>,
        John Crispin <john@...ozen.org>, Biwen Li <biwen.li@....com>,
        Chris Brandt <chris.brandt@...esas.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>
Subject: Re: [PATCH] of/irq: Add a quirk for controllers with their own
 definition of interrupt-map

Hi Marc,

On Mon, 2021-11-22 at 10:30 +0000, Marc Zyngier wrote:
> Since 041284181226 ("of/irq: Allow matching of an interrupt-map local
> to an interrupt controller"), a handful of interrupt controllers have
> stopped working correctly. This is due to the DT exposing a non-sensical
> interrupt-map property, and their drivers relying on the kernel ignoring
> this property.
> 
> Since we cannot realistically fix this terrible behaviour, add a quirk
> for the limited set of devices that have implemented this monster,
> and document that this is a pretty bad practice.
> 
> Cc: Rob Herring <robh@...nel.org>
> Cc: John Crispin <john@...ozen.org>
> Cc: Biwen Li <biwen.li@....com>
> Cc: Chris Brandt <chris.brandt@...esas.com>
> Cc: Geert Uytterhoeven <geert+renesas@...der.be>
> Signed-off-by: Marc Zyngier <maz@...nel.org>

Thanks for the patch. As far as I can tell, this restores the old behaviour from
5.15 for "realtek,rtl-intc" and things work as expected.

Best,
Sander