linux-kernel - Re: [PATCH] arm64: dts: freescale: imx8mq: Disable noc dts node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211123085841.GX31998@dragon>
Date:   Tue, 23 Nov 2021 16:58:42 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Abel Vesa <abel.vesa@....com>,
        Martin Kepplinger <martin.kepplinger@...i.sm>
Cc:     Martin Kepplinger <martink@...teo.de>,
        Rob Herring <robh@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        NXP Linux Team <linux-imx@....com>,
        linux-arm-kernel@...ts.infradead.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        devicetree@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: freescale: imx8mq: Disable noc dts node

On Thu, Nov 11, 2021 at 01:16:09PM +0200, Abel Vesa wrote:
> Adding interconnect properties to the consumer nodes creates
> a dependency on noc device. The imx-bus devfreq driver is not usable
> without the full interconnect support. The interconnect is not yet
> working on i.MX platforms. The devlink created on device_add makes
> the lcdif and other nodes that have the interconnect properties
> wait for the noc (imx-bus driver) to probe first.
> 
> To make sure the interconnect consumers (nodes that have interconnect
> properties already added) will still probe, lets disable the noc node
> for now. Once the interconnect on i.MX platforms is fully functional,
> the status of the noc node can be changed.
> 
> Fixes: ad1abc8a03fdbc05b ("arm64: dts: imx8mq: Add interconnect for lcdif")

Martin,

Do you have any comment?  So your commit added something untested?

Shawn

> Signed-off-by: Abel Vesa <abel.vesa@....com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 972766b67a15..f3182878f596 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -1305,6 +1305,7 @@ noc: interconnect@...00000 {
>  			fsl,ddrc = <&ddrc>;
>  			#interconnect-cells = <1>;
>  			operating-points-v2 = <&noc_opp_table>;
> +			status = "disabled";
>  
>  			noc_opp_table: opp-table {
>  				compatible = "operating-points-v2";
> -- 
> 2.31.1
>