linux-kernel - Re: linux-next: build failure after merge of the regulator tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9df5380a-3fb6-8c1b-677a-3159e99c4869@fi.rohmeurope.com>
Date:   Tue, 23 Nov 2021 09:26:45 +0000
From:   "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>
CC:     "heiko.carstens@...ibm.com" <heiko.carstens@...ibm.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the regulator tree

Hi again,

On 11/23/21 09:41, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the regulator tree, today's linux-next build (s390
> allmodconfig) failed like this:
> 
> include/linux/mfd/rohm-generic.h:93:12: error: 'rohm_regulator_set_voltage_sel_restricted' defined but not used [-Werror=unused-function]
> cc1: all warnings being treated as errors
> 
> Caused by commit
> 
>    8b6e88555971 ("regulator: rohm-regulator: add helper for restricted voltage setting")

As a second thought - do we need such a stub function at all? I guess 
anyone who is actually adding a call to the 
rohm_regulator_set_voltage_sel_restricted()  helper should also have the 
implementation selected. Failing to do so is probably indication of an 
error. Compile testing could perhaps be an exception but this is 
currently not supported.

Should I just drop the stub or make it inline? Am I overlooking something?

Best Regards
	-- Matti Vaittinen

-- 
The Linux Kernel guy at ROHM Semiconductors

Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~ this year is the year of a signature writers block ~~