linux-kernel - Re: [PATCH v2 2/2] i2c:imx: Add an extra read at the end of an I2C slave read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YZzCWfvq5k2JaMka@kunai>
Date:   Tue, 23 Nov 2021 11:28:41 +0100
From:   Wolfram Sang <wsa@...nel.org>
To:     minyard@....org
Cc:     Oleksij Rempel <o.rempel@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andrew Manley <andrew.manley@...lingtech.com>
Subject: Re: [PATCH v2 2/2] i2c:imx: Add an extra read at the end of an I2C
 slave read

On Fri, Nov 12, 2021 at 07:39:56AM -0600, minyard@....org wrote:
> From: Corey Minyard <minyard@....org>
> 
> The I2C slave interface expects that the driver will read ahead one
> byte.  The IMX driver/device doesn't do this, but simulate it so that
> read operations get their index set correctly.

From what I understand, the patch is correct but the description may be
wrong?

AFAIU the patch adds the slave event I2C_SLAVE_READ_PROCESSED to the
case when the last byte was transferred. We as the client got a NAK from
the controller. However, the byte WAS processed, so the event is ok and
not a dummy?


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)