linux-kernel - Re: [PATCH 1/2] media: i2c: imx274: simplify probe function by adding local variable dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YZzPj4ILWyp4Ouz9@paasikivi.fi.intel.com>
Date:   Tue, 23 Nov 2021 13:25:03 +0200
From:   Sakari Ailus <sakari.ailus@...ux.intel.com>
To:     Eugen Hristev <eugen.hristev@...rochip.com>
Cc:     leonl@...pardimaging.com, linux-media@...r.kernel.org,
        skomatineni@...dia.com, luca@...aceresoli.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] media: i2c: imx274: simplify probe function by
 adding local variable dev

Hi Eugen,

On Tue, Nov 23, 2021 at 01:15:20PM +0200, Eugen Hristev wrote:
> Simplify probe function by adding a local variable dev instead of using
> &client->dev all the time.
> 
> Signed-off-by: Eugen Hristev <eugen.hristev@...rochip.com>

It's not really wrong to do this, but is it useful?

You can't even unwrap a single line, the lines are just made a little bit
shorter.

-- 
Kind regards,

Sakari Ailus