linux-kernel - Re: [PATCH V2] tty: serial: imx: disable UCR4_OREN in .stop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 23 Nov 2021 14:03:13 +0100
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Sherry Sun <sherry.sun@....com>
Cc:     gregkh@...uxfoundation.org, jirislaby@...nel.org,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-imx@....com
Subject: Re: [PATCH V2] tty: serial: imx: disable UCR4_OREN in .stop_rx()
 instead of .shutdown()

On Tue, Nov 23, 2021 at 06:51:22PM +0800, Sherry Sun wrote:
> From: Fugang Duan <fugang.duan@....com>
> 
> Disable the UCR4_OREN bit in .stop_rx() before the uart receiver is disabled
> maybe better than in the .shutdown() function.

There should be a better incentive than "maybe it's better to do this".
My expectation is that you verify there is indeed an issue and then fix
that with a descriptive commit log that convinces this is indeed a fix.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)