linux-kernel - Re: [PATCH net 1/2] rxrpc: Fix rxrpc_peer leak in rxrpc_look_up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAB9dFdtG9N_N=PKXaYwkpT5pvgSK1rTjNOGd4i6+hPcjr9hSHw@mail.gmail.com>
Date:   Tue, 23 Nov 2021 10:12:12 -0400
From:   Marc Dionne <marc.dionne@...istor.com>
To:     Eiichi Tsukata <eiichi.tsukata@...anix.com>
Cc:     David Howells <dhowells@...hat.com>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        linux-afs@...ts.infradead.org, netdev <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net 1/2] rxrpc: Fix rxrpc_peer leak in rxrpc_look_up_bundle()

On Sun, Nov 21, 2021 at 12:17 AM Eiichi Tsukata
<eiichi.tsukata@...anix.com> wrote:
>
> Need to call rxrpc_put_peer() for bundle candidate before kfree() as it
> holds a ref to rxrpc_peer.
>
> Fixes: 245500d853e9 ("rxrpc: Rewrite the client connection manager")
> Signed-off-by: Eiichi Tsukata <eiichi.tsukata@...anix.com>
> ---
>  net/rxrpc/conn_client.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/net/rxrpc/conn_client.c b/net/rxrpc/conn_client.c
> index dbea0bfee48e..46dcb33888ff 100644
> --- a/net/rxrpc/conn_client.c
> +++ b/net/rxrpc/conn_client.c
> @@ -328,6 +328,7 @@ static struct rxrpc_bundle *rxrpc_look_up_bundle(struct rxrpc_conn_parameters *c
>         return candidate;
>
>  found_bundle_free:
> +       rxrpc_put_peer(candidate->params.peer);
>         kfree(candidate);
>  found_bundle:
>         rxrpc_get_bundle(bundle);
> --
> 2.33.1

Reviewed-by: Marc Dionne <marc.dionne@...istor.com>

Marc