linux-kernel - Re: [PATCH] spidev: Make probe to fail early if a spidev compatible is used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YZ0A6rrpDlN6e5Vh@sirena.org.uk>
Date:   Tue, 23 Nov 2021 14:55:38 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Javier Martinez Canillas <javierm@...hat.com>
Cc:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, linux-spi@...r.kernel.org,
        kernel@...gutronix.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spidev: Make probe to fail early if a spidev compatible
 is used

On Fri, Nov 19, 2021 at 09:32:32AM +0100, Javier Martinez Canillas wrote:
> On 11/19/21 08:40, Uwe Kleine-König wrote:

> > Not this affects also devices that use

> > 	compatible = "myvender,devicename", "spidev";

> This is indeed a corner case and I'm less sure what the kernel should do
> about it. I just learned now that of_device_is_compatible() return value

TBH I feel like that falls into the same bucket as any other uses of
spidev so I'm not overly worried.  Grepping around it looks like we have
no examples of this in tree, only a few plain spidevs in DTs for older
platforms that were most likely converted from board files and *probably*
aren't too relevant at this point.

> Or just consider DT nodes with a general "spidev" compatible string to
> also not be valid. I would lean towards this one I think.

Yes, I think so.  Your other options are worth exploring if it turns out
to be an issue but hopefully it's not.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)