linux-kernel - Re: [PATCH v4 12/12] watchdog: s3c2410: Add Exynos850 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211123161247.GD2326185@roeck-us.net>
Date:   Tue, 23 Nov 2021 08:12:47 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Sam Protsenko <semen.protsenko@...aro.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        linux-watchdog@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org,
        Wim Van Sebroeck <wim@...ux-watchdog.org>
Subject: Re: [PATCH v4 12/12] watchdog: s3c2410: Add Exynos850 support

On Mon, Nov 22, 2021 at 05:14:35PM +0200, Sam Protsenko wrote:
> On Sun, 21 Nov 2021 at 18:57, Sam Protsenko <semen.protsenko@...aro.org> wrote:
> >
> > Exynos850 is a bit different from SoCs already supported in WDT driver:
> >   - AUTOMATIC_WDT_RESET_DISABLE register is removed, so its value is
> >     always 0; .disable_auto_reset callback is not set for that reason
> >   - MASK_WDT_RESET_REQUEST register is replaced with
> >     CLUSTERx_NONCPU_IN_EN register; instead of masking (disabling) WDT
> >     reset interrupt it's now enabled with the same value; .mask_reset
> >     callback is reused for that functionality though
> >   - To make WDT functional, WDT counter needs to be enabled in
> >     CLUSTERx_NONCPU_OUT register; it's done using .enable_counter
> >     callback
> >
> > Also Exynos850 has two CPU clusters, each has its own dedicated WDT
> > instance. Different PMU registers and bits are used for each cluster. So
> > driver data is now modified in probe, adding needed info depending on
> > cluster index passed from device tree.
> >
> > Signed-off-by: Sam Protsenko <semen.protsenko@...aro.org>
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> > Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> > ---
> 
> Hi Guenter,
> 
> I've resent the whole series, but I can see you already applied my
> previous series to your watchdog-next branch. So this patch is the
> only one that actually changed in the whole series (with fixes for
> 0-day warning).
> 

No worries. What you did is ok.

Guenter