linux-kernel - Re: [PATCH 11/11] ACPI / scan: Create platform device for CLSA0100 ACPI nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <756f813c-cc3e-7ddf-e5db-cf6c874f907e@opensource.cirrus.com>
Date:   Tue, 23 Nov 2021 17:11:02 +0000
From:   Lucas tanure <tanureal@...nsource.cirrus.com>
To:     Hans de Goede <hdegoede@...hat.com>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>, Mark Gross <markgross@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Mark Brown <broonie@...nel.org>, Takashi Iwai <tiwai@...e.com>,
        Kailang Yang <kailang@...ltek.com>,
        Shuming Fan <shumingf@...ltek.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        David Rhodes <david.rhodes@...rus.com>,
        Vitaly Rodionov <vitalyr@...nsource.cirrus.com>
CC:     Jeremy Szu <jeremy.szu@...onical.com>,
        Hui Wang <hui.wang@...onical.com>,
        Werner Sembach <wse@...edocomputers.com>,
        Chris Chiu <chris.chiu@...onical.com>,
        Cameron Berkenpas <cam@...-zeon.de>,
        Sami Loone <sami@...ne.fi>, Elia Devito <eliadevito@...il.com>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Jack Yu <jack.yu@...ltek.com>, "Arnd Bergmann" <arnd@...db.de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        "Alexandre Belloni" <alexandre.belloni@...tlin.com>,
        <alsa-devel@...a-project.org>, <linux-acpi@...r.kernel.org>,
        <patches@...nsource.cirrus.com>,
        <platform-driver-x86@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 11/11] ACPI / scan: Create platform device for CLSA0100
 ACPI nodes

On 11/23/21 17:05, Hans de Goede wrote:
> Hi Lucas,
> 
> On 11/23/21 17:31, Lucas Tanure wrote:
>> The ACPI device with CLSA0100 is a sound card with multiple
>> instances of CS35L41.
>>
>> We add an ID to the I2C multi instantiate list to enumerate
>> all I2C slaves correctly.
>>
>> Signed-off-by: Lucas Tanure <tanureal@...nsource.cirrus.com>
>> ---
>>   drivers/acpi/scan.c                          | 1 +
>>   drivers/platform/x86/i2c-multi-instantiate.c | 7 +++++++
>>   2 files changed, 8 insertions(+)
>>
>> diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
>> index 2c80765670bc..16827a33e93b 100644
>> --- a/drivers/acpi/scan.c
>> +++ b/drivers/acpi/scan.c
>> @@ -1708,6 +1708,7 @@ static bool acpi_device_enumeration_by_parent(struct acpi_device *device)
>>   		{"BSG2150", },
>>   		{"INT33FE", },
>>   		{"INT3515", },
>> +		{"CLSA0100", },
>>   		{}
>>   	};
>>   
>> diff --git a/drivers/platform/x86/i2c-multi-instantiate.c b/drivers/platform/x86/i2c-multi-instantiate.c
>> index 4956a1df5b90..ed25a0adc656 100644
>> --- a/drivers/platform/x86/i2c-multi-instantiate.c
>> +++ b/drivers/platform/x86/i2c-multi-instantiate.c
>> @@ -147,6 +147,12 @@ static const struct i2c_inst_data int3515_data[]  = {
>>   	{}
>>   };
>>   
>> +static const struct i2c_inst_data clsa0100_data[]  = {
>> +	{ "cs35l41-hda", IRQ_RESOURCE_GPIO, 0 },
>> +	{ "cs35l41-hda", IRQ_RESOURCE_GPIO, 0 },
> 
> This suggests that both amplifiers are using the same GPIO pin as shared
> IRQ, is that correct ? Can you share an acpidump of the laptop's DSDT tables ?
> 
> Regards,
> 
> Hans
> 

DSDT attached.
Yes, both amps share the same IRQ gpio.

> 
> 
> 
>> +	{}
>> +};
>> +
>>   /*
>>    * Note new device-ids must also be added to i2c_multi_instantiate_ids in
>>    * drivers/acpi/scan.c: acpi_device_enumeration_by_parent().
>> @@ -155,6 +161,7 @@ static const struct acpi_device_id i2c_multi_inst_acpi_ids[] = {
>>   	{ "BSG1160", (unsigned long)bsg1160_data },
>>   	{ "BSG2150", (unsigned long)bsg2150_data },
>>   	{ "INT3515", (unsigned long)int3515_data },
>> +	{ "CLSA0100", (unsigned long)clsa0100_data },
>>   	{ }
>>   };
>>   MODULE_DEVICE_TABLE(acpi, i2c_multi_inst_acpi_ids);
>>
> 

View attachment "dsdt.dsl" of type "text/x-dsl" (1156776 bytes)