linux-kernel - Re: [PATCH 10/11] hda: cs35l41: Add support for CS35L41 in HDA systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a2ef9f32-0a92-d8cc-8e4a-7d4d4abcc7e9@linux.intel.com>
Date:   Tue, 23 Nov 2021 11:16:37 -0600
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     tanureal@...nsource.cirrus.com,
        "Rafael J.Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <markgross@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Mark Brown <broonie@...nel.org>, Takashi Iwai <tiwai@...e.com>,
        Kailang Yang <kailang@...ltek.com>,
        Shuming Fan <shumingf@...ltek.com>,
        David Rhodes <david.rhodes@...rus.com>,
        Vitaly Rodionov <vitalyr@...nsource.cirrus.com>,
        Jeremy Szu <jeremy.szu@...onical.com>,
        Hui Wang <hui.wang@...onical.com>,
        Werner Sembach <wse@...edocomputers.com>,
        Chris Chiu <chris.chiu@...onical.com>,
        Cameron Berkenpas <cam@...-zeon.de>,
        Sami Loone <sami@...ne.fi>, Elia Devito <eliadevito@...il.com>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Jack Yu <jack.yu@...ltek.com>, Arnd Bergmann <arnd@...db.de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        alsa-devel@...a-project.org, linux-acpi@...r.kernel.org,
        patches@...nsource.cirrus.com, platform-driver-x86@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 10/11] hda: cs35l41: Add support for CS35L41 in HDA
 systems



On 11/23/21 11:06 AM, tanureal@...nsource.cirrus.com wrote:
> On 11/23/21 4:59 PM, Pierre-Louis Bossart
> <pierre-louis.bossart@...ux.intel.com> wrote:
>>
>> > +#ifdef CONFIG_ACPI
>> > +static const struct acpi_device_id cs35l41_acpi_hda_match[] = {
>> > +    {"CLSA0100", 0 },
>>
>> I could be wrong but this doesn't look like a legit ACPI _HID?
>>
>> Cirrus Logic can use 'CIR', "CLI", or 'CSC' PNP ID, or an PCI ID.
>>
>> in the past you used
>>
>> +#ifdef CONFIG_ACPI
>> +static const struct acpi_device_id cs35l41_acpi_match[] = {
>> +    { "CSC3541", 0 }, /* Cirrus Logic PnP ID + part ID */
>> +    {},
>> +};
>> +MODULE_DEVICE_TABLE(acpi, cs35l41_acpi_match);
>> +#endif
>>
>>
>>
> 
> This ACPI _HID is already released, there is nothing I can do about it.
> Future devices will use 'CSC' PnP ID.

ok, add a comment then that you're adding support for an
already-released value that's not compliant.