linux-kernel - Re: [kbuild-all] Re: [PATCH] crypto: fix flexible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4514c646-cae1-cd50-8a1c-1a550593c7a8@intel.com>
Date:   Wed, 24 Nov 2021 11:17:23 +0800
From:   "Chen, Rong A" <rong.a.chen@...el.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>,
        Julia Lawall <julia.lawall@...ia.fr>
Cc:     Megha Dey <megha.dey@...el.com>, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org,
        Tomasz Kantecki <tomasz.kantecki@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>,
        linux-crypto@...r.kernel.org
Subject: Re: [kbuild-all] Re: [PATCH] crypto: fix flexible_array.cocci
 warnings

Hi Herbert,

On 11/20/2021 12:06 PM, Herbert Xu wrote:
> On Fri, Nov 12, 2021 at 11:56:22AM +0100, Julia Lawall wrote:
>> From: kernel test robot <lkp@...el.com>
>>
>>   Zero-length and one-element arrays are deprecated, see
>>   Documentation/process/deprecated.rst
>>   Flexible-array members should be used instead.
>>
>> Generated by: scripts/coccinelle/misc/flexible_array.cocci
>>
>> Reported-by: kernel test robot <lkp@...el.com>
>> Signed-off-by: kernel test robot <lkp@...el.com>
>> Signed-off-by: Julia Lawall <julia.lawall@...ia.fr>
>> ---
>>
>> tree:   https://github.com/meghadey/crypto crypto-avx512
>> head:   9c8c2ca77f6e2575a130bddb9767d068e1162d71
>> commit: 377aede9f10ee28be954473668bc6d33c6c9db75 [5/6] crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ

Sorry for the noise, this patch tries to fix the above commit, it seems
the commit is still in the private tree, we have fixed it to avoid 
sending to maintainers.

Best Regards,
Rong Chen

>> :::::: branch date: 7 weeks ago
>> :::::: commit date: 7 weeks ago
>>
>>   aesni-intel_glue.c |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- a/arch/x86/crypto/aesni-intel_glue.c
>> +++ b/arch/x86/crypto/aesni-intel_glue.c
>> @@ -87,7 +87,7 @@ struct gcm_context_data {
>>   	u64 partial_block_len;
>>   	u64 unused;
>>   	/* Allocate space for hash_keys later */
>> -	u8 hash_keys[0];
>> +	u8 hash_keys[];
> 
> Which tree did this come from? Not only is this not zero in my
> tree, but it seems to have never been zero in the git history.
> 
> Thanks,
>