linux-kernel - RE: [Intel-wired-lan] [PATCH] igb: remove never changed variable `ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BYAPR11MB33678E55E77438B1B16B990EFC619@BYAPR11MB3367.namprd11.prod.outlook.com>
Date:   Wed, 24 Nov 2021 13:01:59 +0000
From:   "G, GurucharanX" <gurucharanx.g@...el.com>
To:     Jason Wang <wangborong@...rlc.com>,
        "kuba@...nel.org" <kuba@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "davem@...emloft.net" <davem@...emloft.net>
Subject: RE: [Intel-wired-lan] [PATCH] igb: remove never changed variable
 `ret_val'



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Jason Wang
> Sent: Sunday, November 14, 2021 11:32 AM
> To: kuba@...nel.org
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Jason Wang
> <wangborong@...rlc.com>; intel-wired-lan@...ts.osuosl.org;
> davem@...emloft.net
> Subject: [Intel-wired-lan] [PATCH] igb: remove never changed variable `ret_val'
> 
> The variable used for return status in `igb_write_xmdio_reg' function is never
> changed  and this function is just need return 0. Thus, the `ret_val' can be
> removed and return 0 at the end of the `igb_write_xmdio_reg' function.
> 
> Signed-off-by: Jason Wang <wangborong@...rlc.com>
> ---
>  drivers/net/ethernet/intel/igb/e1000_i210.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 

Tested-by: Gurucharan G <gurucharanx.g@...el.com> (A Contingent worker at Intel)