linux-kernel - Re: [PATCH 2/2] mmc: dw_mmc: use standard "mmc" alias stem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3b78d0e4656f4df6bf548cd9f7557ec0@hyperstone.com>
Date:   Wed, 24 Nov 2021 12:52:48 +0000
From:   Christian Löhle <CLoehle@...erstone.com>
To:     Jaehoon Chung <jh80.chung@...sung.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        John Keeping <john@...anate.com>
CC:     "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] mmc: dw_mmc: use standard "mmc" alias stem

Sorry for hijacking this thread.

From: Jaehoon Chung <jh80.chung@...sung.com>
Sent: Wednesday, November 24, 2021 10:54 AM
To: Ulf Hansson; John Keeping
Cc: linux-mmc@...r.kernel.org; linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] mmc: dw_mmc: use standard "mmc" alias stem

>>> The old "mshc" lookup is kept for backwards compatibility.
>> 
>> The mshc alias is really weird!
>> 
>> It looks like some leftover from when the dw_mmc controller supported
>> multiple slots. This support was dropped a long time ago, simply
>> because it never really worked - and it was not worth trying to. Only
>> one slot per controller is supported.
>
>As Ulf mentioned, dw_mmc controller can be supported multiple slot.
>But I didn't see its case to use multiple slot. And I had been done to drop a long time ago.
>
>mshc was used because of Mobile Storage Host Controller.

I assume this means you are open to a rework for dw_mmc?
I have a bigger patch for dw_mmc that I work on myself.
I removed the slot functionality at the start because there is no way for me to verify that I did not break this feature in the meantime.
But if it never worked and there is no platform for it, then removing this is fine for everyone?
Otherwise I probably would submit my rework for staging.

Regards,
Christian=
Hyperstone GmbH | Reichenaustr. 39a  | 78467 Konstanz
Managing Director: Dr. Jan Peter Berns.
Commercial register of local courts: Freiburg HRB381782