linux-kernel - Re: [PATCH v2] x86/sev-es: Fix SEV-ES INS/OUTS instructions for word, dword, and qword

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YZ4+EYF8dhrzRy2h@suse.de>
Date:   Wed, 24 Nov 2021 14:28:49 +0100
From:   Joerg Roedel <jroedel@...e.de>
To:     Michael Sterritt <sterritt@...gle.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        "H. Peter Anvin" <hpa@...or.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Tom Lendacky <thomas.lendacky@....com>,
        linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        virtualization@...ts.linux-foundation.org,
        linux-coco@...ts.linux.dev, Paolo Bonzini <pbonzini@...hat.com>,
        marcorr@...gle.com, pgonda@...gle.com
Subject: Re: [PATCH v2] x86/sev-es: Fix SEV-ES INS/OUTS instructions for
 word, dword, and qword

On Fri, Nov 19, 2021 at 03:27:57PM -0800, Michael Sterritt wrote:
> Properly type the operands being passed to __put_user()/__get_user().
> Otherwise, these routines truncate data for dependent instructions
> (e.g., INSW) and only read/write one byte.
> 
> Tested: Tested by sending a string with `REP OUTSW` to a port and then
> reading it back in with `REP INSW` on the same port. Previous behavior
> was to only send and receive the first char of the size. For example,
> word operations for "abcd" would only read/write "ac". With change, the
> full string is now written and read back.
> 
> Fixes: f980f9c31a923 (x86/sev-es: Compile early handler code into kernel image)
> Reviewed-by: Paolo Bonzini <pbonzini@...hat.com>
> Reviewed-by: Marc Orr <marcorr@...gle.com>
> Reviewed-by: Peter Gonda <pgonda@...gle.com>
> Signed-off-by: Michael Sterritt <sterritt@...gle.com>

Reviewed-by: Joerg Roedel <jroedel@...e.de>