linux-kernel - Re: [PATCH v3 1/2] fs: proc: store PDE()->data into inode->i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211124125428.esjaqfsloq6owur6@wittgenstein>
Date:   Wed, 24 Nov 2021 13:54:28 +0100
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     Muchun Song <songmuchun@...edance.com>
Cc:     akpm@...ux-foundation.org, adobriyan@...il.com,
        gladkov.alexey@...il.com, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] fs: proc: store PDE()->data into inode->i_private

On Wed, Nov 24, 2021 at 04:19:55PM +0800, Muchun Song wrote:
> PDE_DATA(inode) is introduced to get user private data and hide the
> layout of struct proc_dir_entry. The inode->i_private is used to do
> the same thing as well. Save a copy of user private data to inode->
> i_private when proc inode is allocated. This means the user also can
> get their private data by inode->i_private.
> 
> Introduce pde_data() to wrap inode->i_private so that we can remove
> PDE_DATA() from fs/proc/generic.c and make PTE_DATE() as a wrapper
> of pde_data(). It will be easier if we decide to remove PDE_DATE()
> in the future.
> 
> Signed-off-by: Muchun Song <songmuchun@...edance.com>
> ---

Seems like a good idea to me.
Acked-by: Christian Brauner <christian.brauner@...ntu.com>