linux-kernel - Re: [PATCH] staging: r8188eu: use max() and min() macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH1kMwRcEwc64XjPAXbJUPFsLTei2pmzP3r_6ZVWQ+NFkaa57g@mail.gmail.com>
Date:   Wed, 24 Nov 2021 20:26:41 +0530
From:   Vihas Mak <makvihas@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Larry.Finger@...inger.net, Phillip Potter <phil@...lpotter.co.uk>,
        Greg KH <gregkh@...uxfoundation.org>, straube.linux@...il.com,
        nathan@...nel.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: use max() and min() macros

>> Please run scripts/checkpatch.pl on your patches.

>> CHECK: Alignment should match open parenthesis
>> #41: FILE: drivers/staging/r8188eu/core/rtw_wlan_util.c:723:

Ahh sorry, my bad. Will resend v2 after fixing that.

On Wed, Nov 24, 2021 at 6:44 PM Dan Carpenter <dan.carpenter@...cle.com> wrote:
>
> On Wed, Nov 24, 2021 at 04:55:51AM +0530, Vihas Mak wrote:
>
> > +
> > +                     min_MPDU_spacing = max(pmlmeinfo->HT_caps.u.HT_cap_element.AMPDU_para & 0x1c,
> > +                                                     pIE->data[i] & 0x1c);
>
> Please run scripts/checkpatch.pl on your patches.
>
> CHECK: Alignment should match open parenthesis
> #41: FILE: drivers/staging/r8188eu/core/rtw_wlan_util.c:723:
> +                       min_MPDU_spacing = max(pmlmeinfo->HT_caps.u.HT_cap_element.AMPDU_para & 0x1c,
> +                                                       pIE->data[i] & 0x1c);
>
> regards,
> dan carpenter
>


-- 
Thanks,
Vihas