linux-kernel - Re: [PATCH 3/4] Bluetooth: btmtksdio: fix resume failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <C3BBFD94-0A2A-4BA1-9892-86CB2956F982@holtmann.org>
Date:   Wed, 24 Nov 2021 16:21:05 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Sean Wang <sean.wang@...iatek.com>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        "Mark-YW Chen (陳揚文)" 
        <Mark-YW.Chen@...iatek.com>, Soul.Huang@...iatek.com,
        YN.Chen@...iatek.com, Leon.Yen@...iatek.com,
        Eric-SY.Chang@...iatek.com, Deren.Wu@...iatek.com,
        km.lin@...iatek.com, robin.chiu@...iatek.com,
        Eddie.Chen@...iatek.com, ch.yeh@...iatek.com,
        posh.sun@...iatek.com, ted.huang@...iatek.com,
        Eric.Liang@...iatek.com, Stella.Chang@...iatek.com,
        Tom.Chou@...iatek.com, steve.lee@...iatek.com, jsiuda@...gle.com,
        frankgor@...gle.com, jemele@...gle.com, abhishekpandit@...gle.com,
        michaelfsun@...gle.com, mcchou@...omium.org, shawnku@...gle.com,
        linux-bluetooth@...r.kernel.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] Bluetooth: btmtksdio: fix resume failure

Hi Sean,

> btmtksdio have to rely on MMC_PM_KEEP_POWER in pm_flags to avoid that
> SDIO power is being shut off during the device is in suspend. That fixes
> the SDIO command fails to access the bus after the device is resumed.
> 
> Fixes: 7f3c563c575e7 ("Bluetooth: btmtksdio: Add runtime PM support to SDIO based Bluetooth")
> Co-developed-by: Mark-yw Chen <mark-yw.chen@...iatek.com>
> Signed-off-by: Mark-yw Chen <mark-yw.chen@...iatek.com>
> Signed-off-by: Sean Wang <sean.wang@...iatek.com>
> ---
> drivers/bluetooth/btmtksdio.c | 2 ++
> 1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth/btmtksdio.c
> index 4c46c62e4623..cae1fcd15512 100644
> --- a/drivers/bluetooth/btmtksdio.c
> +++ b/drivers/bluetooth/btmtksdio.c
> @@ -1040,6 +1040,8 @@ static int btmtksdio_runtime_suspend(struct device *dev)
> 	if (!test_bit(HCI_RUNNING, &bdev->hdev->flags))
> 		return 0;
> 
> +	sdio_set_host_pm_flags(func, MMC_PM_KEEP_POWER);
> +
> 	sdio_claim_host(bdev->func);
> 
> 	sdio_writel(bdev->func, C_FW_OWN_REQ_SET, MTK_REG_CHLPCR, &err);

if this makes sense without 2/4 patch, then please re-send.

Regards

Marcel