linux-kernel - Re: [PATCH] tools/thermal: remove unneeded variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 24 Nov 2021 17:28:11 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     cgel.zte@...il.com
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Amit Kucheria <amitk@...nel.org>,
        "Zhang, Rui" <rui.zhang@...el.com>, ran.jianping@....com.cn,
        Linux PM <linux-pm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] tools/thermal: remove unneeded variable

On Fri, Nov 12, 2021 at 10:09 AM <cgel.zte@...il.com> wrote:
>
> From: ran jianping <ran.jianping@....com.cn>
>
> Fix the following coccicheck review:
> /tools/thermal/tmon/pid.c:57:5-8: Unneeded variable
>
> Remove unneeded variable used to store return value.
>
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: ran jianping <ran.jianping@....com.cn>
> ---
>  tools/thermal/tmon/pid.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/thermal/tmon/pid.c b/tools/thermal/tmon/pid.c
> index c54edb4f630c..296f69c00c57 100644
> --- a/tools/thermal/tmon/pid.c
> +++ b/tools/thermal/tmon/pid.c
> @@ -54,7 +54,6 @@ static double xk_1, xk_2; /* input temperature x[k-#] */
>   */
>  int init_thermal_controller(void)
>  {
> -       int ret = 0;
>
>         /* init pid params */
>         p_param.ts = ticktime;
> @@ -65,7 +64,7 @@ int init_thermal_controller(void)
>
>         p_param.t_target = target_temp_user;
>
> -       return ret;
> +       return 0;
>  }
>
>  void controller_reset(void)
> --

Applied as 5.17 material, thanks!