linux-kernel - RE: [PATCH] acpi/tables: Add AEST in ACPI Table Definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <TYCPR01MB6160ABE0B422073A35F3A58EE9619@TYCPR01MB6160.jpnprd01.prod.outlook.com>
Date:   Wed, 24 Nov 2021 00:52:57 +0000
From:   "ishii.shuuichir@...itsu.com" <ishii.shuuichir@...itsu.com>
To:     'Hanjun Guo' <guohanjun@...wei.com>,
        "rafael@...nel.org" <rafael@...nel.org>,
        "lenb@...nel.org" <lenb@...nel.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "lorenzo.pieralisi@....com" <lorenzo.pieralisi@....com>,
        "sudeep.holla@....com" <sudeep.holla@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "ishii.shuuichir@...itsu.com" <ishii.shuuichir@...itsu.com>
Subject: RE: [PATCH] acpi/tables: Add AEST in ACPI Table Definition

Hi, Hanjun.

Thanks for the comment.
We apologize for the delay in replying due to my vacation.

We understood this to be a point in response to the description of the patch comment.
What do you think of the following description?

When We added AEST using the Upgrading ACPI tables via initrd function,
the kernel could not recognize the AEST, 
so added the AEST table to the list to enable the table upgrade function.

Best regards,
Shuuichirou.

> -----Original Message-----
> From: Hanjun Guo <guohanjun@...wei.com>
> Sent: Friday, November 19, 2021 5:05 PM
> To: Ishii, Shuuichirou/石井 周一郎 <ishii.shuuichir@...itsu.com>;
> rafael@...nel.org; lenb@...nel.org; linux-acpi@...r.kernel.org;
> linux-kernel@...r.kernel.org
> Cc: lorenzo.pieralisi@....com; sudeep.holla@....com;
> linux-arm-kernel@...ts.infradead.org
> Subject: Re: [PATCH] acpi/tables: Add AEST in ACPI Table Definition
> 
> On 2021/11/5 12:16, Shuuichirou Ishii wrote:
> > When We added AEST using the Upgrading ACPI tables via initrd
> > function, the kernel could not recognize the AEST, so We added AEST
> > the ACPI table definition.
> 
> Maybe "so add the AEST table to the list to enable the table upgrade function." is
> better?
> 
> >
> > Signed-off-by: Shuuichirou Ishii <ishii.shuuichir@...itsu.com>
> > ---
> >   drivers/acpi/tables.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c index
> > 71419eb16e09..2699bf7e21ab 100644
> > --- a/drivers/acpi/tables.c
> > +++ b/drivers/acpi/tables.c
> > @@ -500,7 +500,7 @@ static const char table_sigs[][ACPI_NAMESEG_SIZE]
> __initconst = {
> >   	ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT,
> >   	ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT,
> >   	ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT,
> > -	ACPI_SIG_NHLT };
> > +	ACPI_SIG_NHLT, ACPI_SIG_AEST };
> >
> >   #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)
> 
> Other than that, I'm fine with this patch.
> 
> Acked-by: Hanjun Guo <guohanjun@...wei.com>
> 
> Thanks
> Hanjun