linux-kernel - Re: [GIT PULL] tracing/uprobe: Fix uprobe_perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=whYWvdKrFY3-xcRFqyxAMnhMGsmU=0gYWYWuRrR7mFV-A@mail.gmail.com>
Date:   Wed, 24 Nov 2021 10:30:24 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Jiri Olsa <jolsa@...hat.com>,
        Masami Hiramatsu <mhiramat@...nel.org>
Subject: Re: [GIT PULL] tracing/uprobe: Fix uprobe_perf_open probes iteration

On Wed, Nov 24, 2021 at 10:27 AM Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
> Instead, you should do something like
>
>         list_for_each_entry(pu, trace_probe_probe_list(tp), tp.list) {

That 'pu' is a typo, it should be 'tu'.

The patch itself got it right, I think.

HOWEVER. Despite the patch itself getting it right, I want to point
out that that was mostly by luck than anything else.

The patch is ENTIRELY UNTESTED.

Because that's how I roll, as you should all know by now.

                  Linus