linux-kernel - Re: [PATCH v6 00/14] genirq: Cleanup the abuse of irq_set_affinity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bl29l5c6.ffs@tglx>
Date:   Wed, 24 Nov 2021 20:30:01 +0100
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Nitesh Lal <nilal@...hat.com>, Juri Lelli <juri.lelli@...hat.com>,
        Marcelo Tosatti <mtosatti@...hat.com>
Cc:     linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
        linux-scsi@...r.kernel.org, netdev@...r.kernel.org,
        davem@...emloft.net, ajit.khaparde@...adcom.com,
        sriharsha.basavapatna@...adcom.com, somnath.kotur@...adcom.com,
        huangguangbin2@...wei.com, huangdaode@...wei.com,
        Frederic Weisbecker <frederic@...nel.org>,
        Alex Belits <abelits@...vell.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>, rostedt@...dmis.org,
        Peter Zijlstra <peterz@...radead.org>,
        Jesse Brandeburg <jesse.brandeburg@...el.com>,
        Robin Murphy <robin.murphy@....com>,
        Ingo Molnar <mingo@...nel.org>, jbrandeb@...nel.org,
        akpm@...uxfoundation.org, sfr@...b.auug.org.au,
        stephen@...workplumber.org, rppt@...ux.vnet.ibm.com,
        chris.friesen@...driver.com, Marc Zyngier <maz@...nel.org>,
        Neil Horman <nhorman@...driver.com>, pjwaskiewicz@...il.com,
        Stefan Assmann <sassmann@...hat.com>,
        Tomas Henzl <thenzl@...hat.com>, james.smart@...adcom.com,
        Dick Kennedy <dick.kennedy@...adcom.com>,
        Ken Cox <jkc@...hat.com>, faisal.latif@...el.com,
        shiraz.saleem@...el.com, tariqt@...dia.com,
        Alaa Hleihel <ahleihel@...hat.com>,
        Kamal Heib <kheib@...hat.com>, borisp@...dia.com,
        saeedm@...dia.com,
        "Nikolova, Tatyana E" <tatyana.e.nikolova@...el.com>,
        "Ismail, Mustafa" <mustafa.ismail@...el.com>,
        Al Stone <ahs3@...hat.com>,
        Leon Romanovsky <leonro@...dia.com>,
        Chandrakanth Patil <chandrakanth.patil@...adcom.com>,
        bjorn.andersson@...aro.org, chunkuang.hu@...nel.org,
        yongqiang.niu@...iatek.com, baolin.wang7@...il.com,
        Petr Oros <poros@...hat.com>, Ming Lei <minlei@...hat.com>,
        Ewan Milne <emilne@...hat.com>, jejb@...ux.ibm.com,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        kabel@...nel.org, Viresh Kumar <viresh.kumar@...aro.org>,
        Jakub Kicinski <kuba@...nel.org>, kashyap.desai@...adcom.com,
        Sumit Saxena <sumit.saxena@...adcom.com>,
        shivasharan.srikanteshwara@...adcom.com,
        sathya.prakash@...adcom.com,
        Sreekanth Reddy <sreekanth.reddy@...adcom.com>,
        suganath-prabu.subramani@...adcom.com, ley.foon.tan@...el.com,
        jbrunet@...libre.com, johannes@...solutions.net,
        snelson@...sando.io, lewis.hanly@...rochip.com, benve@...co.com,
        _govind@....com, jassisinghbrar@...il.com
Subject: Re: [PATCH v6 00/14] genirq: Cleanup the abuse of
 irq_set_affinity_hint()

Nitesh,

On Mon, Sep 13 2021 at 10:34, Nitesh Lal wrote:
> On Fri, Sep 3, 2021 at 11:25 AM Nitesh Narayan Lal <nitesh@...hat.com> wrote:
>>
>> The drivers currently rely on irq_set_affinity_hint() to either set the
>> affinity_hint that is consumed by the userspace and/or to enforce a custom
>> affinity.
>>
>> irq_set_affinity_hint() as the name suggests is originally introduced to
>> only set the affinity_hint to help the userspace in guiding the interrupts
>> and not the affinity itself. However, since the commit
>>
>>         e2e64a932556 "genirq: Set initial affinity in irq_set_affinity_hint()"

sorry for ignoring this. It fell through the cracks.

>> Thomas Gleixner (1):
>>   genirq: Provide new interfaces for affinity hints

Did I actually write this?

> Any suggestions on what should be the next steps here? Unfortunately, I haven't
> been able to get any reviews on the following two patches:
>   be2net: Use irq_update_affinity_hint
>   hinic: Use irq_set_affinity_and_hint
>
> One option would be to proceed with the remaining patches and I can try
> posting these two again when I post patches for the remaining drivers?

The more general question is whether I should queue all the others or
whether some subsystem would prefer to pull in a tagged commit on top of
rc1. I'm happy to carry them all of course.

Thanks,

        tglx