linux-kernel - Re: [PATCH] tsnep: fix platform_no_drv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANr-f5wsqOMZaw1fHWWEQcYS2LUYqZ+zuwtaL0Jq1YaVzB5vHQ@mail.gmail.com>
Date:   Wed, 24 Nov 2021 21:36:05 +0100
From:   Gerhard Engleder <gerhard@...leder-embedded.com>
To:     kernel test robot <lkp@...el.com>
Cc:     kbuild-all@...ts.01.org,
        Linux Memory Management List <linux-mm@...ck.org>,
        Jakub Kicinski <kuba@...nel.org>,
        netdev <netdev@...r.kernel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tsnep: fix platform_no_drv_owner.cocci warnings

>
> From: kernel test robot <lkp@...el.com>
>
> drivers/net/ethernet/engleder/tsnep_main.c:1263:3-8: No need to set .owner here. The core will do it.
>
>  Remove .owner field if calls are used which set it automatically
>
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>
> CC: Gerhard Engleder <gerhard@...leder-embedded.com>
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: kernel test robot <lkp@...el.com>
> ---
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   4b74e088fef6ce8cc513f935ce236c38bdf5f67b
> commit: 403f69bbdbadb2e601f725be2d00b4ccc7b61c9d [2745/3376] tsnep: Add TSN endpoint Ethernet MAC driver
> :::::: branch date: 11 hours ago
> :::::: commit date: 2 days ago
>
>  tsnep_main.c |    1 -
>  1 file changed, 1 deletion(-)
>
> --- a/drivers/net/ethernet/engleder/tsnep_main.c
> +++ b/drivers/net/ethernet/engleder/tsnep_main.c
> @@ -1260,7 +1260,6 @@ MODULE_DEVICE_TABLE(of, tsnep_of_match);
>  static struct platform_driver tsnep_driver = {
>         .driver = {
>                 .name = TSNEP,
> -               .owner = THIS_MODULE,
>                 .of_match_table = of_match_ptr(tsnep_of_match),
>         },
>         .probe = tsnep_probe,

Reviewed-by: Gerhard Engleder <gerhard@...leder-embedded.com>