linux-kernel - Re: [PATCH 1/2] arm64: dts: renesas: ulcb: Merge hdmi0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YZ67btQ8IxlIBdsh@pendragon.ideasonboard.com>
Date:   Thu, 25 Nov 2021 00:23:42 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
Cc:     linux-renesas-soc@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Geert Uytterhoeven <geert@...der.be>,
        Magnus Damm <magnus.damm@...il.com>,
        Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH 1/2] arm64: dts: renesas: ulcb: Merge hdmi0_con

Hi Kieran,

Thank you for the patch.

On Wed, Nov 24, 2021 at 03:28:14PM +0000, Kieran Bingham wrote:
> The remote endpoint for the hdmi connector is specfied through a
> reference to the hdmi0_con endpoint, which is in the same file.
> 
> Simplify by specifying the remote-endpoint directly in the hdmi0_con
> endpoint.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>

I saw this earlier today and made a note to fix it. You were faster :-)

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  arch/arm64/boot/dts/renesas/ulcb.dtsi | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi b/arch/arm64/boot/dts/renesas/ulcb.dtsi
> index 7edffe7f8cfa..a7e93df4ced8 100644
> --- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
> @@ -48,6 +48,7 @@ hdmi0-out {
>  
>  		port {
>  			hdmi0_con: endpoint {
> +				remote-endpoint = <&rcar_dw_hdmi0_out>;
>  			};
>  		};
>  	};
> @@ -199,10 +200,6 @@ dw_hdmi0_snd_in: endpoint {
>  	};
>  };
>  
> -&hdmi0_con {
> -	remote-endpoint = <&rcar_dw_hdmi0_out>;
> -};
> -
>  &i2c2 {
>  	pinctrl-0 = <&i2c2_pins>;
>  	pinctrl-names = "default";

-- 
Regards,

Laurent Pinchart