linux-kernel - Re: [PATCH] drm/i915/dmabuf: remove duplicate include in i915_gem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87mtltnc70.fsf@intel.com>
Date:   Wed, 24 Nov 2021 11:18:59 +0200
From:   Jani Nikula <jani.nikula@...ux.intel.com>
To:     cgel.zte@...il.com
Cc:     joonas.lahtinen@...ux.intel.com, rodrigo.vivi@...el.com,
        tvrtko.ursulin@...ux.intel.com, airlied@...ux.ie, daniel@...ll.ch,
        matthew.auld@...el.com, thomas.hellstrom@...ux.intel.com,
        jason@...kstrand.net, chris@...is-wilson.co.uk,
        maarten.lankhorst@...ux.intel.com, yao.jing2@....com.cn,
        gregkh@...uxfoundation.org, intel-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] drm/i915/dmabuf: remove duplicate include in
  i915_gem_dmabuf.c

On Wed, 24 Nov 2021, cgel.zte@...il.com wrote:
> From: Yao Jing <yao.jing2@....com.cn>
>
> 'asm/smp.h' included in 'drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c' is
> duplicated. It is clearly included on the 12 line.
>
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Yao Jing <yao.jing2@....com.cn>

The correct fix is [1].

If you keep sending patches from cgel.zte@...il.com, you need to add
your Signed-off-by too.

BR,
Jani.


[1] https://patchwork.freedesktop.org/patch/msgid/20211122135758.85444-1-tvrtko.ursulin@linux.intel.com



> ---
>  drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c b/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c
> index f291cf4c3886..5712b6b5f285 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c
> @@ -17,9 +17,7 @@
>  
>  MODULE_IMPORT_NS(DMA_BUF);
>  
> -#if defined(CONFIG_X86)
> -#include <asm/smp.h>
> -#else
> +#if !defined(CONFIG_X86)
>  #define wbinvd_on_all_cpus() \
>  	pr_warn(DRIVER_NAME ": Missing cache flush in %s\n", __func__)
>  #endif

-- 
Jani Nikula, Intel Open Source Graphics Center