linux-kernel - [PATCH] binder: reframe comment to avoid warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20211124093002.9795-1-ajithpv.linux@gmail.com>
Date:   Wed, 24 Nov 2021 15:00:02 +0530
From:   Ajith P V <ajithpv.linux@...il.com>
To:     gregkh@...uxfoundation.org, arve@...roid.com, tkjos@...roid.com,
        maco@...roid.com, joel@...lfernandes.org, christian@...uner.io,
        hridya@...gle.com, surenb@...gle.com
Cc:     linux-kernel@...r.kernel.org, Ajith P V <ajithpv.linux@...il.com>
Subject: [PATCH] binder: reframe comment to avoid warning

binder.c file comment produce warning with checkpatch as below:
WARNING: waitqueue_active without comment

Placing the waitqueue_active comment just above waitqueue_active() avoid
this warning.

Signed-off-by: Ajith P V <ajithpv.linux@...il.com>
---
 drivers/android/binder.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index 49fb74196d02..e1695535f252 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -4424,10 +4424,12 @@ static int binder_thread_release(struct binder_proc *proc,
 	/*
 	 * If this thread used poll, make sure we remove the waitqueue
 	 * from any epoll data structures holding it with POLLFREE.
-	 * waitqueue_active() is safe to use here because we're holding
-	 * the inner lock.
 	 */
 	if ((thread->looper & BINDER_LOOPER_STATE_POLL) &&
+	    /*
+	     * waitqueue_active() is safe to use here because we're holding
+	     * the inner lock.
+	     */
 	    waitqueue_active(&thread->wait)) {
 		wake_up_poll(&thread->wait, EPOLLHUP | POLLFREE);
 	}
-- 
2.17.1