linux-kernel - Re: [PATCH] mm: fix the type of a parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YZ/yBxJlznnraBe2@casper.infradead.org>
Date:   Thu, 25 Nov 2021 20:28:55 +0000
From:   Matthew Wilcox <willy@...radead.org>
To:     Yixuan Cao <caoyixuan2019@...il.szu.edu.cn>
Cc:     akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: fix the type of a parameter

On Fri, Nov 26, 2021 at 03:43:01AM +0800, Yixuan Cao wrote:
> The type of "last_migrate_reason" in struct page_owner is short.
> However, the type of "reason" in the argument list of function
> __set_page_owner_migrate_reason is int,
> which is inconsistent.

Did you try compiling this patch?

> Signed-off-by: Yixuan Cao <caoyixuan2019@...il.szu.edu.cn>
> ---
>  mm/page_owner.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/page_owner.c b/mm/page_owner.c
> index 4f924957ce7a..4c23e910caf9 100644
> --- a/mm/page_owner.c
> +++ b/mm/page_owner.c
> @@ -182,7 +182,7 @@ noinline void __set_page_owner(struct page *page, unsigned short order,
>  	__set_page_owner_handle(page_ext, handle, order, gfp_mask);
>  }
>  
> -void __set_page_owner_migrate_reason(struct page *page, int reason)
> +void __set_page_owner_migrate_reason(struct page *page, short reason)
>  {
>  	struct page_ext *page_ext = lookup_page_ext(page);
>  	struct page_owner *page_owner;
> -- 
> 2.31.1
> 
> 
> 
>