linux-kernel - Re: [PATCH v1 00/10] misc: at25: Code cleanups and improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a3Pu-ygd9dkhS=d2ZGKjbt0V=mdxaEG8tXUhueSKMJXQg@mail.gmail.com>
Date:   Thu, 25 Nov 2021 23:03:26 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Prchal <jiri.prchal@...ignal.cz>
Subject: Re: [PATCH v1 00/10] misc: at25: Code cleanups and improvements

On Thu, Nov 25, 2021 at 10:31 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> Code cleanups and improvements. Please read individual commit messages.
>
> Series depends on the fixes series [1] sent earlier.
>
> [1]: https://lore.kernel.org/lkml/20211125212729.86585-2-andriy.shevchenko@linux.intel.com/T/#u
>
> Andy Shevchenko (10):
>   misc: at25: Use at25->chip instead of local chip everywhere in
>     ->probe()
>   misc: at25: Unshadow error codes in at25_fw_to_chip()
>   misc: at25: Check new property ("address-width") first
>   misc: at25: Get platform data via dev_get_platdata()
>   misc: at25: Get rid of intermediate storage for AT25 chip data
>   misc: at25: Switch to use BIT() instead of custom approaches
>   misc: at25: Factor out at_fram_to_chip()
>   misc: at25: Reorganize headers for better maintenance
>   misc: at25: Replace commas by spaces in the ID tables
>   misc: at25: Align comment style

These also look good to me,

Acked-by: Arnd Bergmann <arnd@...db.de>

It would be nice to change the three remaining board files that fill
struct spi_eeprom so they use device properties and unify the
rest of the probe path. Not sure how much of a change that would
be.

         Arnd