linux-kernel - Re: [PATCH] pata_falcon: Add missing _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9713ea83-b4e7-4eee-5ab1-7fb2dccb4ccd@linux-m68k.org>
Date:   Fri, 26 Nov 2021 09:36:56 +1100 (AEDT)
From:   Finn Thain <fthain@...ux-m68k.org>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
cc:     Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
        Michael Schmitz <schmitzmic@...il.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Jens Axboe <axboe@...nel.dk>, linux-ide@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pata_falcon: Add missing __iomem annotations

On Thu, 25 Nov 2021, Geert Uytterhoeven wrote:

> 
> Yeah, you do have to be careful with macros that derive a size from the 
> type of the passed data.  The *{in,out}sw() functions do not suffer from 
> that: they are defined to operate on a 16-bit I/O register. It is very 
> unlikely these semantics will ever change.
> 
> Here I'm more worried about the other danger: keeping casts will silence 
> any warning that may be introduced in a future change to the driver 
> code.
> 

Fair enough. I'll send v2.