linux-kernel - [PATCH v2 1/4] input: ti_am335x_tsc: set ADCREFM for X configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20211125224642.21011-2-dariobin@libero.it>
Date:   Thu, 25 Nov 2021 23:46:39 +0100
From:   Dario Binacchi <dariobin@...ero.it>
To:     linux-kernel@...r.kernel.org
Cc:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        linux-input@...r.kernel.org, Felipe Balbi <balbi@...com>,
        Zubair Lutfullah <zubair.lutfullah@...il.com>,
        Grygorii Strashko <grygorii.strashko@...com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Dave Gerlach <d-gerlach@...com>,
        "Andrew F . Davis" <afd@...com>, Vignesh R <vigneshr@...com>,
        Lee Jones <lee.jones@...aro.org>,
        Wolfram Sang <wsa@...nel.org>, Brad Griffis <bgriffis@...com>,
        Jeff Lance <j-lance1@...com>, Rachna Patil <rachna@...com>,
        Dario Binacchi <dariobin@...ero.it>
Subject: [PATCH v2 1/4] input: ti_am335x_tsc: set ADCREFM for X configuration

As reported by the STEPCONFIG[1-16] registered field descriptions of the
TI reference manual, for the ADC "in single ended, SEL_INM_SWC_3_0 must
be 1xxx".

Unlike the Y and Z coordinates, this bit has not been set for the step
configuration registers used to sample the X coordinate.

Fixes: 1b8be32e691 ("Input: add support for TI Touchscreen controller")
Signed-off-by: Dario Binacchi <dariobin@...ero.it>
---

(no changes since v1)

 drivers/input/touchscreen/ti_am335x_tsc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c
index 83e685557a19..fd3ffdd23470 100644
--- a/drivers/input/touchscreen/ti_am335x_tsc.c
+++ b/drivers/input/touchscreen/ti_am335x_tsc.c
@@ -131,7 +131,8 @@ static void titsc_step_config(struct titsc *ts_dev)
 	u32 stepenable;
 
 	config = STEPCONFIG_MODE_HWSYNC |
-			STEPCONFIG_AVG_16 | ts_dev->bit_xp;
+			STEPCONFIG_AVG_16 | ts_dev->bit_xp |
+			STEPCONFIG_INM_ADCREFM;
 	switch (ts_dev->wires) {
 	case 4:
 		config |= STEPCONFIG_INP(ts_dev->inp_yp) | ts_dev->bit_xn;
-- 
2.17.1