linux-kernel - Re: [PATCH v2] staging: r8188eu: use max() and min() macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211125065945.GL6514@kadam>
Date:   Thu, 25 Nov 2021 09:59:45 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Vihas Mak <makvihas@...il.com>
Cc:     Larry.Finger@...inger.net, phil@...lpotter.co.uk,
        gregkh@...uxfoundation.org, straube.linux@...il.com,
        nathan@...nel.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: r8188eu: use max() and min() macros

On Thu, Nov 25, 2021 at 12:34:36AM +0530, Vihas Mak wrote:
> use max() and min() macros to fix following cocci warnings:
> 
> 	drivers/staging/r8188eu/core/rtw_wlan_util.c:719: WARNING opportunity for min()
> 	drivers/staging/r8188eu/core/rtw_wlan_util.c:724: WARNING opportunity for max()
> 
> Signed-off-by: Vihas Mak <makvihas@...il.com>
> ---
> v1 -> v2:
> - fixed checkpatch issues (parenthesis alignment).

Looks good.  Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com>

regards,
dan carpenter