linux-kernel - Re: [PATCH] staging: r8188eu: remove unnecessary NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211125070914.GM6514@kadam>
Date:   Thu, 25 Nov 2021 10:09:14 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Vihas Mak <makvihas@...il.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>, Larry.Finger@...inger.net,
        Phillip Potter <phil@...lpotter.co.uk>,
        straube.linux@...il.com, martin@...ser.cx,
        Pavel Skripkin <paskripkin@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: remove unnecessary NULL check

On Thu, Nov 25, 2021 at 07:02:20AM +0530, Vihas Mak wrote:
> >> And are you sure this ever could be NULL?
> Yes.
> 
> The function rtw_free_netdev() performs a NULL check before actually
> freeing the structure, so the "if (pnetdev)" check isn't really
> necessary before calling rtw_free_netdev().
> That's the reason why I removed that check.
> 

That's not the question Greg and I asked.  Re-read the emails.

regards,
dan carpenter