linux-kernel - Re: [PATCH 1/2] sched/pelt: Remove redundant variable in __accumulate_pelt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YZ9dGGVphUpGnmI2@hirez.programming.kicks-ass.net>
Date:   Thu, 25 Nov 2021 10:53:28 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Tang Yizhou <tangyizhou@...wei.com>
Cc:     linux-kernel@...r.kernel.org, mingo@...hat.com,
        juri.lelli@...hat.com, vincent.guittot@...aro.org
Subject: Re: [PATCH 1/2] sched/pelt: Remove redundant variable in
 __accumulate_pelt_segments

On Thu, Nov 25, 2021 at 11:00:18AM +0800, Tang Yizhou wrote:
> As the comment of function accumulate_sum() describes the equation clearly,
> There is no need to use a redundant variable c3. Let's make a comment for
> d3 directly.

Why bother? Surely the compiler is clever enough to figure out the same
and avoid instantiating the variable. All you've done is made the code
less obvious.